tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DynamicTablesPkg: PPTT: Fix uninitialized memory usage 

On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.

This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
This commit is contained in:
Sami Mujawar 2019-08-05 16:43:37 +01:00 committed by mergify[bot]
parent 4817953949
commit 4d23a7ec84
1 changed files with 29 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
View File

@ -1203,6 +1203,17 @@ BuildPpttTable (
Generator->ProcHierarchyNodeCount, Generator->ProcHierarchyNodeCount,
&NodeIndexer &NodeIndexer
); );
DEBUG ((
DEBUG_INFO,
" ProcHierarchyNodeCount = %d\n" \
" ProcHierarchyNodeOffset = 0x%x\n" \
" ProcHierarchyNodeIndexedList = 0x%p\n",
Generator->ProcHierarchyNodeCount,
ProcHierarchyNodeOffset,
Generator->ProcHierarchyNodeIndexedList
));
} }
// Include the size of Cache Type Structures and index them // Include the size of Cache Type Structures and index them
@ -1215,6 +1226,15 @@ BuildPpttTable (
Generator->CacheStructCount, Generator->CacheStructCount,
&NodeIndexer &NodeIndexer
); );
DEBUG ((
DEBUG_INFO,
" CacheStructCount = %d\n" \
" CacheStructOffset = 0x%x\n" \
" CacheStructIndexedList = 0x%p\n",
Generator->CacheStructCount,
CacheStructOffset,
Generator->CacheStructIndexedList
));
} }
// Include the size of ID Type Structures and index them // Include the size of ID Type Structures and index them
@ -1227,6 +1247,15 @@ BuildPpttTable (
Generator->IdStructCount, Generator->IdStructCount,
&NodeIndexer &NodeIndexer
); );
DEBUG ((
DEBUG_INFO,
" IdStructCount = %d\n" \
" IdStructOffset = 0x%x\n" \
" IdStructIndexedList = 0x%p\n",
Generator->IdStructCount,
IdStructOffset,
Generator->IdStructIndexedList
));
} }
DEBUG (( DEBUG ((
@ -1238,36 +1267,6 @@ BuildPpttTable (
TableSize TableSize
)); ));
DEBUG ((
DEBUG_INFO,
" ProcHierarchyNodeCount = %d\n" \
" ProcHierarchyNodeOffset = 0x%x\n" \
" ProcHierarchyNodeIndexedList = 0x%p\n",
Generator->ProcHierarchyNodeCount,
ProcHierarchyNodeOffset,
Generator->ProcHierarchyNodeIndexedList
));
DEBUG ((
DEBUG_INFO,
" CacheStructCount = %d\n" \
" CacheStructOffset = 0x%x\n" \
" CacheStructIndexedList = 0x%p\n",
Generator->CacheStructCount,
CacheStructOffset,
Generator->CacheStructIndexedList
));
DEBUG ((
DEBUG_INFO,
" IdStructCount = %d\n" \
" IdStructOffset = 0x%x\n" \
" IdStructIndexedList = 0x%p\n",
Generator->IdStructCount,
IdStructOffset,
Generator->IdStructIndexedList
));
// Allocate the Buffer for the PPTT table // Allocate the Buffer for the PPTT table
*Table = (EFI_ACPI_DESCRIPTION_HEADER*)AllocateZeroPool (TableSize); *Table = (EFI_ACPI_DESCRIPTION_HEADER*)AllocateZeroPool (TableSize);
if (*Table == NULL) { if (*Table == NULL) {