tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ShellPkg: remove memory leak in file handle list 

The shell was not freeing sufficient memory when freeing a list of files.  The structure contained a pointer which was being left behind.  I made a new function to replace the shared freeing function which frees the “Path” member of the SHELL_COMMAND_FILE_HANDLE structure.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15073 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Jaben Carsey 2014-01-09 18:05:24 +00:00 committed by jcarsey
parent 4922715d85
commit 4f67c7ffa1
1 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
View File

@ -1,7 +1,7 @@
/** @file
Provides interface to shell internal functions for shell commands.
Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@ -100,6 +100,37 @@ ShellCommandLibConstructor (
return (RETURN_SUCCESS);
}
/**
Frees list of file handles.
@param[in] List The list to free.
**/
VOID
EFIAPI
FreeFileHandleList (
IN BUFFER_LIST *List
)
{
BUFFER_LIST *BufferListEntry;
if (List == NULL){
return;
}
//
// enumerate through the buffer list and free all memory
//
for ( BufferListEntry = ( BUFFER_LIST *)GetFirstNode(&List->Link)
; !IsListEmpty (&List->Link)
; BufferListEntry = (BUFFER_LIST *)GetFirstNode(&List->Link)
){
RemoveEntryList(&BufferListEntry->Link);
ASSERT(BufferListEntry->Buffer != NULL);
SHELL_FREE_NON_NULL(((SHELL_COMMAND_FILE_HANDLE*)(BufferListEntry->Buffer))->Path);
SHELL_FREE_NON_NULL(BufferListEntry->Buffer);
SHELL_FREE_NON_NULL(BufferListEntry);
}
}
/**
Destructor for the library. free any resources.
@ -169,7 +200,7 @@ ShellCommandLibDestructor (
}
}
if (!IsListEmpty(&mFileHandleList.Link)){
FreeBufferList(&mFileHandleList);
FreeFileHandleList(&mFileHandleList);
}
if (mProfileList != NULL) {