From 524feaa32f0fde6b22a40e606b848b6aa42b6751 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Tue, 5 Mar 2024 12:38:37 +0100 Subject: [PATCH] OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl declares a bogus ProcessLibraryConstructorList() for the OvmfPkg/RiscVVirt SEC module. Rely on AutoGen for (properly) declaring ProcessLibraryConstructorList(). Remove the correct, but superfluous, declaration as well. Build-tested with: build -a RISCV64 -b DEBUG -m OvmfPkg/RiscVVirt/Sec/SecMain.inf \ -p OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc -t GCC5 Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Sunil V L Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek Message-Id: <20240305113843.68812-5-lersek@redhat.com> Reviewed-by: Sunil V L Reviewed-by: Jiewen Yao Acked-by: Gerd Hoffmann --- OvmfPkg/RiscVVirt/Sec/Memory.c | 1 - OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------ OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/OvmfPkg/RiscVVirt/Sec/Memory.c b/OvmfPkg/RiscVVirt/Sec/Memory.c index 7c6d920bd2..14c9569c78 100644 --- a/OvmfPkg/RiscVVirt/Sec/Memory.c +++ b/OvmfPkg/RiscVVirt/Sec/Memory.c @@ -25,7 +25,6 @@ Module Name: #include #include #include -#include #include #include #include diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h b/OvmfPkg/RiscVVirt/Sec/SecMain.h index 7c7650f0d2..fd7c48f876 100644 --- a/OvmfPkg/RiscVVirt/Sec/SecMain.h +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h @@ -49,18 +49,6 @@ SecStartup ( IN VOID *DeviceTreeAddress ); -/** - Auto-generated function that calls the library constructors for all of the module's - dependent libraries. This function must be called by the SEC Core once a stack has - been established. - -**/ -VOID -EFIAPI -ProcessLibraryConstructorList ( - VOID - ); - /** Perform Platform PEIM initialization. diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf b/OvmfPkg/RiscVVirt/Sec/SecMain.inf index 0e2a5785e8..73df0ee4cb 100644 --- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf @@ -8,7 +8,7 @@ ## [Defines] - INF_VERSION = 0x0001001B + INF_VERSION = 1.30 BASE_NAME = SecMainRiscV64 FILE_GUID = 16740C0A-AA84-4F62-A06D-AE328057AE07 MODULE_TYPE = SEC