Clean up BaseIoLibIntrinsic according to review comments.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5876 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
vanjeff 2008-09-11 08:59:52 +00:00
parent 36e90351bd
commit 5dedabbb4e
6 changed files with 14 additions and 25 deletions

View File

@ -2,8 +2,8 @@
# Component description file for Intrinsic Base Io Library # Component description file for Intrinsic Base Io Library
# #
# I/O Library that uses compiler intrinsics to perform IN and OUT instructions # I/O Library that uses compiler intrinsics to perform IN and OUT instructions
# for IA-32 and x64. It also performs direct memory access for MMIO services. # for IA-32, x64 and IPF. It also performs direct memory access for MMIO services.
# Copyright (c) 2007, Intel Corporation. # Copyright (c) 2007 - 2008, Intel Corporation.
# #
# All rights reserved. This program and the accompanying materials # All rights reserved. This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License # are licensed and made available under the terms and conditions of the BSD License
@ -33,23 +33,21 @@
[Sources.common] [Sources.common]
IoLibMmioBuffer.c IoLibMmioBuffer.c
BaseIoLibIntrinsicInternal.h BaseIoLibIntrinsicInternal.h
IoHighLevel.c
[Sources.Ia32] [Sources.Ia32]
IoHighLevel.c
IoLibGcc.c | GCC IoLibGcc.c | GCC
IoLibMsc.c | MSFT IoLibMsc.c | MSFT
IoLibIcc.c | INTEL IoLibIcc.c | INTEL
IoLib.c IoLib.c
[Sources.X64] [Sources.X64]
IoHighLevel.c
IoLibGcc.c | GCC IoLibGcc.c | GCC
IoLibMsc.c | MSFT IoLibMsc.c | MSFT
IoLibIcc.c | INTEL IoLibIcc.c | INTEL
IoLib.c IoLib.c
[Sources.IPF] [Sources.IPF]
IoHighLevel.c
IoLibIpf.c IoLibIpf.c
[Packages] [Packages]

View File

@ -3,7 +3,7 @@
This file includes package header files, dependent library classes. This file includes package header files, dependent library classes.
Copyright (c) 2007, Intel Corporation. Copyright (c) 2007 - 2008, Intel Corporation.
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -19,10 +19,8 @@
#include <Base.h> #include <Base.h>
#include <Library/IoLib.h> #include <Library/IoLib.h>
#include <Library/BaseLib.h> #include <Library/BaseLib.h>
#include <Library/DebugLib.h> #include <Library/DebugLib.h>
#include <Library/PcdLib.h>
#endif #endif

View File

@ -4,7 +4,7 @@
All assertions for bit field operations are handled bit field functions in the All assertions for bit field operations are handled bit field functions in the
Base Library. Base Library.
Copyright (c) 2006, Intel Corporation<BR> Copyright (c) 2006 - 2008, Intel Corporation<BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -21,9 +21,6 @@
**/ **/
//
// Include common header file for this module.
//
#include "BaseIoLibIntrinsicInternal.h" #include "BaseIoLibIntrinsicInternal.h"
/** /**

View File

@ -2,7 +2,7 @@
I/O Library. This file has compiler specifics for ICC as there I/O Library. This file has compiler specifics for ICC as there
is no ANSI C standard for doing IO. is no ANSI C standard for doing IO.
Copyright (c) 2006 - 2007, Intel Corporation<BR> All rights Copyright (c) 2006 - 2008, Intel Corporation<BR> All rights
reserved. This program and the accompanying materials are reserved. This program and the accompanying materials are
licensed and made available under the terms and conditions of the BSD License licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -350,9 +350,6 @@ IoWrite16 (
out dx, ax out dx, ax
} }
//
// Never reached return statement.
//
return Value; return Value;
} }

View File

@ -1,7 +1,7 @@
/** @file /** @file
Common I/O Library routines. Common I/O Library routines.
Copyright (c) 2006 - 2007, Intel Corporation<BR> Copyright (c) 2006 - 2008, Intel Corporation<BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -12,10 +12,9 @@
**/ **/
//
// Include common header file for this module.
//
#include "BaseIoLibIntrinsicInternal.h" #include "BaseIoLibIntrinsicInternal.h"
#include <Library/PcdLib.h>
#define MAP_PORT_BASE_TO_MEM(_Port) \ #define MAP_PORT_BASE_TO_MEM(_Port) \
((((_Port) & 0xfffc) << 10) | ((_Port) & 0x0fff)) ((((_Port) & 0xfffc) << 10) | ((_Port) & 0x0fff))

View File

@ -1,7 +1,7 @@
/** @file /** @file
I/O Library MMIO Buffer Functions. I/O Library MMIO Buffer Functions.
Copyright (c) 2007, Intel Corporation<BR> Copyright (c) 2007 - 2008, Intel Corporation<BR>
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -220,7 +220,7 @@ MmioReadBuffer64 (
@param StartAddress Starting address for the MMIO region to be copied to. @param StartAddress Starting address for the MMIO region to be copied to.
@param Length Size in bytes of the copy. @param Length Size in bytes of the copy.
@param Buffer Pointer to a system memory buffer containing the data to write. @param Buffer Pointer to a system memory buffer containing the data to write.
@return Size in bytes of the copy. @return Size in bytes of the copy.
@ -266,7 +266,7 @@ MmioWriteBuffer8 (
If Buffer is not aligned on a 16-bit boundary, then ASSERT(). If Buffer is not aligned on a 16-bit boundary, then ASSERT().
@param StartAddress Starting address for the MMIO region to be copied to. @param StartAddress Starting address for the MMIO region to be copied to.
@param Length Size in bytes of the copy. @param Length Size in bytes of the copy.
@param Buffer Pointer to a system memory buffer containing the data to write. @param Buffer Pointer to a system memory buffer containing the data to write.
@return Size in bytes of the copy. @return Size in bytes of the copy.
@ -320,7 +320,7 @@ MmioWriteBuffer16 (
If Buffer is not aligned on a 32-bit boundary, then ASSERT(). If Buffer is not aligned on a 32-bit boundary, then ASSERT().
@param StartAddress Starting address for the MMIO region to be copied to. @param StartAddress Starting address for the MMIO region to be copied to.
@param Length Size in bytes of the copy. @param Length Size in bytes of the copy.
@param Buffer Pointer to a system memory buffer containing the data to write. @param Buffer Pointer to a system memory buffer containing the data to write.
@return Size in bytes of the copy. @return Size in bytes of the copy.
@ -373,7 +373,7 @@ MmioWriteBuffer32 (
If Buffer is not aligned on a 64-bit boundary, then ASSERT(). If Buffer is not aligned on a 64-bit boundary, then ASSERT().
@param StartAddress Starting address for the MMIO region to be copied to. @param StartAddress Starting address for the MMIO region to be copied to.
@param Length Size in bytes of the copy. @param Length Size in bytes of the copy.
@param Buffer Pointer to a system memory buffer containing the data to write. @param Buffer Pointer to a system memory buffer containing the data to write.
@return Size in bytes of the copy. @return Size in bytes of the copy.