DynamicTablesPkg: AmlLib fix ECC errors

Fix the following ECC reported errors in AmlLib.
  - [1008]  File has invalid Non-ACSII char.
  - [9002]  The function headers should follow Doxygen special
            documentation blocks in section 2.3.5 Comment does NOT
            have tail **/

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
This commit is contained in:
Sami Mujawar 2020-09-21 18:08:56 +01:00 committed by mergify[bot]
parent e4dfb2ffa3
commit 5e0b708f74
10 changed files with 19 additions and 19 deletions

View File

@ -33,7 +33,7 @@ EFIAPI
LinkNode ( LinkNode (
IN AML_OBJECT_NODE * Node, IN AML_OBJECT_NODE * Node,
IN AML_NODE_HEADER * ParentNode, IN AML_NODE_HEADER * ParentNode,
IN AML_OBJECT_NODE ** NewObjectNode OUT AML_OBJECT_NODE ** NewObjectNode
) )
{ {
EFI_STATUS Status; EFI_STATUS Status;
@ -71,7 +71,7 @@ LinkNode (
@param[in] OemId 6-character string OEM identifier. @param[in] OemId 6-character string OEM identifier.
@param[in] OemTableId 8-character string OEM table identifier. @param[in] OemTableId 8-character string OEM table identifier.
@param[in] OemRevision OEM revision number. @param[in] OemRevision OEM revision number.
@param[out] DefinitionBlockTerm The ASL Term handle representing a @param[out] NewRootNode Pointer to the root node representing a
Definition Block. Definition Block.
@retval EFI_SUCCESS Success. @retval EFI_SUCCESS Success.

View File

@ -40,7 +40,7 @@ EFIAPI
LinkRdNode ( LinkRdNode (
IN AML_DATA_NODE * RdNode, IN AML_DATA_NODE * RdNode,
IN AML_OBJECT_NODE * ParentNode, IN AML_OBJECT_NODE * ParentNode,
IN AML_DATA_NODE ** NewRdNode OUT AML_DATA_NODE ** NewRdNode
) )
{ {
EFI_STATUS Status; EFI_STATUS Status;

View File

@ -674,7 +674,7 @@ AmlAddPrefix (
@retval EFI_SUCCESS The function completed successfully. @retval EFI_SUCCESS The function completed successfully.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
*/ **/
STATIC STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI

View File

@ -41,7 +41,7 @@
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory. @retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/ **/
STATIC STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
@ -177,7 +177,7 @@ AmlParseFieldElement (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory. @retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/ **/
STATIC STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI

View File

@ -1320,7 +1320,7 @@ AmlCreateMethodInvocationNode (
// DefExternal := ExternalOp NameString ObjectType ArgumentCount // DefExternal := ExternalOp NameString ObjectType ArgumentCount
// ExternalOp := 0x15 // ExternalOp := 0x15
// ObjectType := ByteData // ObjectType := ByteData
// ArgumentCount := ByteData (0 7) // ArgumentCount := ByteData (0 - 7)
// Read the ArgumentCount. // Read the ArgumentCount.
ArgCountNode = (AML_DATA_NODE*)FixedArgs[EAmlParseIndexTerm2]; ArgCountNode = (AML_DATA_NODE*)FixedArgs[EAmlParseIndexTerm2];
@ -1334,7 +1334,7 @@ AmlCreateMethodInvocationNode (
// MethodInvocation := MethodInvocationOp NameString ArgumentCount // MethodInvocation := MethodInvocationOp NameString ArgumentCount
// MethodInvocationOp := Pseudo Opcode for Method Invocation // MethodInvocationOp := Pseudo Opcode for Method Invocation
// NameString := Method Name // NameString := Method Name
// ArgumentCount := ByteData (0 7) // ArgumentCount := ByteData (0 - 7)
Status = AmlCreateObjectNode ( Status = AmlCreateObjectNode (
AmlGetByteEncodingByOpCode (AML_METHOD_INVOC_OP, 0), AmlGetByteEncodingByOpCode (AML_METHOD_INVOC_OP, 0),
0, 0,
@ -1411,7 +1411,7 @@ error_handler:
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory. @retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/ **/
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
AmlGetMethodInvocationArgCount ( AmlGetMethodInvocationArgCount (

View File

@ -1134,7 +1134,7 @@ AmlParseVariableArguments (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory. @retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/ **/
STATIC STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
@ -1179,7 +1179,7 @@ AmlPopulateRootNode (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory. @retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/ **/
STATIC STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
@ -1287,7 +1287,7 @@ AmlPopulateObjectNode (
@retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_BUFFER_TOO_SMALL No space left in the buffer.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Could not allocate memory. @retval EFI_OUT_OF_RESOURCES Could not allocate memory.
*/ **/
STATIC STATIC
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI

View File

@ -213,7 +213,7 @@ AmlRdIsResourceDataBuffer (
return TRUE; return TRUE;
} }
// TODO Might want to check the CRC when available. // @todo Might want to check the CRC when available.
// An end tag resource data element must be the last element of the list. // An end tag resource data element must be the last element of the list.
// Thus the function should have already returned. // Thus the function should have already returned.
if (AmlRdCompareDescId ( if (AmlRdCompareDescId (

View File

@ -52,7 +52,7 @@ AmlStreamInit (
in the ClonedStream. in the ClonedStream.
@param [in] Stream Pointer to the stream to clone. @param [in] Stream Pointer to the stream to clone.
@param [in] ClonedStream Pointer to the stream to initialize. @param [out] ClonedStream Pointer to the stream to initialize.
@retval EFI_SUCCESS The function completed successfully. @retval EFI_SUCCESS The function completed successfully.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.
@ -97,7 +97,7 @@ AmlStreamClone (
@param [in] Stream Pointer to the stream from which a sub-stream is @param [in] Stream Pointer to the stream from which a sub-stream is
created. created.
@param [in] SubStream Pointer to the stream to initialize. @param [out] SubStream Pointer to the stream to initialize.
@retval EFI_SUCCESS The function completed successfully. @retval EFI_SUCCESS The function completed successfully.
@retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_INVALID_PARAMETER Invalid parameter.

View File

@ -464,7 +464,7 @@ AmlNodeCompareOpCode (
@retval TRUE The Node is an integer node. @retval TRUE The Node is an integer node.
@retval FALSE Otherwise. @retval FALSE Otherwise.
*/ **/
BOOLEAN BOOLEAN
EFIAPI EFIAPI
IsIntegerNode ( IsIntegerNode (
@ -499,7 +499,7 @@ IsIntegerNode (
@retval TRUE The Node is a ZeroOp or OneOp. @retval TRUE The Node is a ZeroOp or OneOp.
@retval FALSE Otherwise. @retval FALSE Otherwise.
*/ **/
BOOLEAN BOOLEAN
EFIAPI EFIAPI
IsSpecialIntegerNode ( IsSpecialIntegerNode (
@ -556,7 +556,7 @@ AmlIsMethodDefinitionNode (
// DefExternal := ExternalOp NameString ObjectType ArgumentCount // DefExternal := ExternalOp NameString ObjectType ArgumentCount
// ExternalOp := 0x15 // ExternalOp := 0x15
// ObjectType := ByteData // ObjectType := ByteData
// ArgumentCount := ByteData (0 7) // ArgumentCount := ByteData (0 - 7)
ObjectType = (AML_DATA_NODE*)AmlGetFixedArgument ( ObjectType = (AML_DATA_NODE*)AmlGetFixedArgument (
(AML_OBJECT_NODE*)Node, (AML_OBJECT_NODE*)Node,
EAmlParseIndexTerm1 EAmlParseIndexTerm1

View File

@ -41,7 +41,7 @@ AmlGetParent (
@return The root node of the tree. @return The root node of the tree.
NULL if error. NULL if error.
*/ **/
AML_ROOT_NODE * AML_ROOT_NODE *
EFIAPI EFIAPI
AmlGetRootNode ( AmlGetRootNode (