tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-27 07:34:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

NetworkPkg/DxeNetLib: Update misleading comment

Browse Source 
Commit 6862b9d538d96363635677198899e1669e591259 makes
more explicit the previous logic of the code anyway, which is that
it is (and was) only a fatal error if all secure algorithms fail.

However the comment updated by this commit seems somewhat
incompatible with that change, and even with the previous code
(which operated as now, just logging different error messages).

This updates the comment to be more compatible with how the
code operates.

Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
This commit is contained in:
Mike Beaton 2024-09-08 11:33:43 +01:00
parent 2842d7f11e
commit 600dc53b6d
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
NetworkPkg/Library/DxeNetLib/DxeNetLib.c
View File

@ -133,10 +133,16 @@ GLOBAL_REMOVE_IF_UNREFERENCED VLAN_DEVICE_PATH mNetVlanDevicePathTemplate = {
// These represent UEFI SPEC defined algorithms that should be supported by // These represent UEFI SPEC defined algorithms that should be supported by
// the RNG protocol and are generally considered secure. // the RNG protocol and are generally considered secure.
// //
// The order of the algorithms in this array is important. This order is the order // Assuming that PcdEnforceSecureRngAlgorithms is TRUE (the default) then
// in which the algorithms will be tried by the RNG protocol. // only the algorithms defined here will be used by the network stack, and
// If your platform needs to use a specific algorithm for the random number generator, // none of these being available will result in an error condition (even if
// then you should place that algorithm first in the array. // some other RNG implementation is available).
//
// If PcdEnforceSecureRngAlgorithms is FALSE this list is not consulted,
// and the first available RNG algorithm is used.
//
// If your platform needs to use a specific algorithm for the random number
// generator, then you should modify this array.
// //
GLOBAL_REMOVE_IF_UNREFERENCED EFI_GUID *mSecureHashAlgorithms[] = { GLOBAL_REMOVE_IF_UNREFERENCED EFI_GUID *mSecureHashAlgorithms[] = {
&gEfiRngAlgorithmSp80090Ctr256Guid, // SP800-90A DRBG CTR using AES-256 &gEfiRngAlgorithmSp80090Ctr256Guid, // SP800-90A DRBG CTR using AES-256