From 60c65d37e2437d6a8bbf4bb1d31751e14650c6fa Mon Sep 17 00:00:00 2001
From: vanjeff <vanjeff@6f19259b-4bc3-4df7-8a09-765794883524>
Date: Thu, 22 Jan 2009 09:07:53 +0000
Subject: [PATCH] remove klocwork issue.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7346 6f19259b-4bc3-4df7-8a09-765794883524
---
 .../GraphicsConsoleDxe/GraphicsConsole.c      | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
index bdcc19e41a..45f447b52f 100644
--- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
+++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
@@ -535,29 +535,28 @@ Error:
     //
     if (Private->GraphicsOutput != NULL) {
       gBS->CloseProtocol (
-            Controller,
-            &gEfiGraphicsOutputProtocolGuid,
-            This->DriverBindingHandle,
-            Controller
-            );
+             Controller,
+             &gEfiGraphicsOutputProtocolGuid,
+             This->DriverBindingHandle,
+             Controller
+             );
     } else if (FeaturePcdGet (PcdUgaConsumeSupport)) {
       gBS->CloseProtocol (
-            Controller,
-            &gEfiUgaDrawProtocolGuid,
-            This->DriverBindingHandle,
-            Controller
-            );
+             Controller,
+             &gEfiUgaDrawProtocolGuid,
+             This->DriverBindingHandle,
+             Controller
+             );
+    }
+
+    if (Private->LineBuffer != NULL) {
+      FreePool (Private->LineBuffer);
     }
 
     //
     // Free private data
     //
-    if (Private != NULL) {
-      if (Private->LineBuffer != NULL) {
-        FreePool (Private->LineBuffer);
-      }
-      FreePool (Private);
-    }
+    FreePool (Private);
   }
 
   return Status;
@@ -642,13 +641,14 @@ GraphicsConsoleControllerDriverStop (
       mFirstAccessFlag = TRUE;
     }
 
+    if (Private->LineBuffer != NULL) {
+      FreePool (Private->LineBuffer);
+    }
+
     //
     // Free our instance data
     //
-    if (Private != NULL) {
-      FreePool (Private->LineBuffer);
-      FreePool (Private);
-    }
+    FreePool (Private);
   }
 
   return Status;