From 65b0d08786888284cd1bb705c58f53a65ae443b0 Mon Sep 17 00:00:00 2001 From: Jeff Brasen Date: Mon, 3 Jun 2024 08:36:17 -0700 Subject: [PATCH] MdeModulePkg/HiiDatabaseDxe: Remove assert for VarStoreId = 0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It is legal for the VarStoreId of a question to be 0 per the UEFI spec: "Specifies the identifier of a previously declared variable store to use when storing the question’s value. A value of zero indicates no associated variable store." Instead of hitting an assert just skip this question as there is no value to return. Signed-off-by: Jeff Brasen --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c index 6e791783a6..426dead981 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c @@ -2101,8 +2101,9 @@ ExtractConfigRequest ( // // Header->VarStoreId == 0 means no storage for this question. // - ASSERT (Header->VarStoreId != 0); - DEBUG ((DEBUG_INFO, "Varstore Id: 0x%x\n", Header->VarStoreId)); + if (Header->VarStoreId == 0) { + continue; + } Storage = FindStorageFromVarId (FormPackage, Header->VarStoreId); ASSERT (Storage != NULL);