tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/DxeNetLib: Rewrite NetblockChecksum function logic 

This commit rewrites the logic for NetblockChecksum. It processes the
checksum of the left-over byte first to prevent possible mis-reports by
static code checkers.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
This commit is contained in:
Hao Wu 2016-11-15 15:39:44 +08:00
parent 9088c61e2d
commit 69e856dfa5
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
MdeModulePkg/Library/DxeNetLib/NetBuffer.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Network library functions providing net buffer operation support. Network library functions providing net buffer operation support.
Copyright (c) 2005 - 2010, Intel Corporation. All rights reserved.<BR> Copyright (c) 2005 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -1661,19 +1661,19 @@ NetblockChecksum (
Sum = 0; Sum = 0;
//
// Add left-over byte, if any
//
if (Len % 2 != 0) {
Sum += *(Bulk + Len - 1);
}
while (Len > 1) { while (Len > 1) {
Sum += *(UINT16 *) Bulk; Sum += *(UINT16 *) Bulk;
Bulk += 2; Bulk += 2;
Len -= 2; Len -= 2;
} }
//
// Add left-over byte, if any
//
if (Len > 0) {
Sum += *(UINT8 *) Bulk;
}
// //
// Fold 32-bit sum to 16 bits // Fold 32-bit sum to 16 bits
// //