tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop() 

Calling DisconnectController() on children isn't part of the job of
EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate
resources allocated in Start(). The disconnection will happen when
both DevicePath and XenBus protocols gets uninstalled.

Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Message-Id: <20190701111403.7007-1-anthony.perard@citrix.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
This commit is contained in:
Anthony PERARD 2019-07-01 12:14:03 +01:00 committed by Laszlo Ersek
parent 64ef66ba8b
commit 6a1f06fadb
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
OvmfPkg/XenBusDxe/XenBusDxe.c
View File

@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop (
continue;
}
ChildData = XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo);
Status = gBS->DisconnectController (ChildData->Handle, NULL, NULL);
if (EFI_ERROR (Status)) {
DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n",
Status));
continue;
}
Status = gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolGuid,
Dev->This->DriverBindingHandle, ChildData->Handle);