From 6aac2db4a11432b11ba92a0d1652d6ec3d81f353 Mon Sep 17 00:00:00 2001 From: Jiaxin Wu Date: Mon, 31 Jul 2017 13:29:40 +0800 Subject: [PATCH] CryptoPkg/TlsLib: Remove the redundant free of BIO objects TLS BIO objects (InBio/OutBio) will be freed by SSL_free() function. So, the following free operation (BIO_free) in TlsFree is redundant. It can be removed directly. Cc: Ye Ting Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Reviewed-by: Long Qin Reviewed-by: Fu Siyuan --- CryptoPkg/Library/TlsLib/TlsInit.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsInit.c b/CryptoPkg/Library/TlsLib/TlsInit.c index e2c9744a44..e524647103 100644 --- a/CryptoPkg/Library/TlsLib/TlsInit.c +++ b/CryptoPkg/Library/TlsLib/TlsInit.c @@ -130,20 +130,12 @@ TlsFree ( } // - // Free the internal TLS and BIO objects. + // Free the internal TLS and related BIO objects. // if (TlsConn->Ssl != NULL) { SSL_free (TlsConn->Ssl); } - if (TlsConn->InBio != NULL) { - BIO_free (TlsConn->InBio); - } - - if (TlsConn->OutBio != NULL) { - BIO_free (TlsConn->OutBio); - } - OPENSSL_free (Tls); }