tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UefiCpuPkg/PiSmmCpuDxeSmm: improve the coding style 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2434

Current code use below loops to enumerate the CPUs:
  for (Index = mMaxNumberOfCpus; Index-- > 0;) {
it has no issue but not easy for the developers to read the code.

Update above code to below style,
  for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
It make the developers easy to read and consistent with other
similar cases in this driver.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Eric Dong <eric.dong@intel.com>
This commit is contained in:
Eric Dong 2020-01-07 08:48:17 +08:00 committed by mergify[bot]
parent 4bb34b6df1
commit 70911f1f4a
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
SMM MP service implementation SMM MP service implementation
Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR> Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR> Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent SPDX-License-Identifier: BSD-2-Clause-Patent
@ -137,7 +137,7 @@ ReleaseAllAPs (
{ {
UINTN Index; UINTN Index;
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (IsPresentAp (Index)) { if (IsPresentAp (Index)) {
ReleaseSemaphore (mSmmMpSyncData->CpuData[Index].Run); ReleaseSemaphore (mSmmMpSyncData->CpuData[Index].Run);
} }
@ -170,7 +170,7 @@ AllCpusInSmmWithExceptions (
CpuData = mSmmMpSyncData->CpuData; CpuData = mSmmMpSyncData->CpuData;
ProcessorInfo = gSmmCpuPrivate->ProcessorInfo; ProcessorInfo = gSmmCpuPrivate->ProcessorInfo;
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (!(*(CpuData[Index].Present)) && ProcessorInfo[Index].ProcessorId != INVALID_APIC_ID) { if (!(*(CpuData[Index].Present)) && ProcessorInfo[Index].ProcessorId != INVALID_APIC_ID) {
if (((Exceptions & ARRIVAL_EXCEPTION_DELAYED) != 0) && SmmCpuFeaturesGetSmmRegister (Index, SmmRegSmmDelayed) != 0) { if (((Exceptions & ARRIVAL_EXCEPTION_DELAYED) != 0) && SmmCpuFeaturesGetSmmRegister (Index, SmmRegSmmDelayed) != 0) {
continue; continue;
@ -305,7 +305,7 @@ SmmWaitForApArrival (
// //
// Send SMI IPIs to bring outside processors in // Send SMI IPIs to bring outside processors in
// //
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (!(*(mSmmMpSyncData->CpuData[Index].Present)) && gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId != INVALID_APIC_ID) { if (!(*(mSmmMpSyncData->CpuData[Index].Present)) && gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId != INVALID_APIC_ID) {
SendSmiIpi ((UINT32)gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId); SendSmiIpi ((UINT32)gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId);
} }
@ -361,7 +361,7 @@ WaitForAllAPsNotBusy (
{ {
UINTN Index; UINTN Index;
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
// //
// Ignore BSP and APs which not call in SMM. // Ignore BSP and APs which not call in SMM.
// //
@ -608,7 +608,7 @@ BSPHandler (
// //
while (TRUE) { while (TRUE) {
PresentCount = 0; PresentCount = 0;
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (*(mSmmMpSyncData->CpuData[Index].Present)) { if (*(mSmmMpSyncData->CpuData[Index].Present)) {
PresentCount ++; PresentCount ++;
} }
@ -1343,7 +1343,7 @@ InternalSmmStartupAllAPs (
} }
CpuCount = 0; CpuCount = 0;
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (IsPresentAp (Index)) { if (IsPresentAp (Index)) {
CpuCount ++; CpuCount ++;
@ -1375,13 +1375,13 @@ InternalSmmStartupAllAPs (
// Here code always use AcquireSpinLock instead of AcquireSpinLockOrFail for not // Here code always use AcquireSpinLock instead of AcquireSpinLockOrFail for not
// block mode. // block mode.
// //
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (IsPresentAp (Index)) { if (IsPresentAp (Index)) {
AcquireSpinLock (mSmmMpSyncData->CpuData[Index].Busy); AcquireSpinLock (mSmmMpSyncData->CpuData[Index].Busy);
} }
} }
for (Index = mMaxNumberOfCpus; Index-- > 0;) { for (Index = 0; Index < mMaxNumberOfCpus; Index++) {
if (IsPresentAp (Index)) { if (IsPresentAp (Index)) {
mSmmMpSyncData->CpuData[Index].Procedure = (EFI_AP_PROCEDURE2) Procedure; mSmmMpSyncData->CpuData[Index].Procedure = (EFI_AP_PROCEDURE2) Procedure;
mSmmMpSyncData->CpuData[Index].Parameter = ProcedureArguments; mSmmMpSyncData->CpuData[Index].Parameter = ProcedureArguments;