From 720624cce0e74cdec8547a8d31b24b39210bf007 Mon Sep 17 00:00:00 2001 From: Eric Dong Date: Mon, 7 Jul 2014 06:30:33 +0000 Subject: [PATCH] Refine code to follow good coding style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15636 6f19259b-4bc3-4df7-8a09-765794883524 --- .../Universal/BdsDxe/BootMaint/BootMaint.h | 1 + .../Universal/BdsDxe/BootMaint/BootOption.c | 11 +++++++---- .../Universal/BdsDxe/BootMaint/Variable.c | 1 + 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootMaint.h b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootMaint.h index 35cb3262a7..098692fa53 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootMaint.h +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootMaint.h @@ -940,6 +940,7 @@ Var_UpdateDriverOrder ( is also updated. @param CallbackData The context data for BMM. + @param FormId The form id. @return EFI_SUCCESS The function completed successfully. @retval EFI_NOT_FOUND If VAR_LEGACY_DEV_ORDER and gEfiLegacyDevOrderVariableGuid EFI Variable can not be found. diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootOption.c b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootOption.c index e1a53135b5..22c2eb3c7e 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootOption.c +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootOption.c @@ -1679,9 +1679,7 @@ GetLegacyDeviceOrder ( { UINTN Index; UINTN OptionIndex; - UINT16 PageIdList [] = {FORM_SET_FD_ORDER_ID, FORM_SET_HD_ORDER_ID, - FORM_SET_CD_ORDER_ID, FORM_SET_NET_ORDER_ID, - FORM_SET_BEV_ORDER_ID}; + UINT16 PageIdList[5]; UINTN PageNum; UINTN VarSize; UINT8 *VarData; @@ -1697,7 +1695,12 @@ GetLegacyDeviceOrder ( UINTN Bit; ASSERT (CallbackData != NULL); - + + PageIdList[0] = FORM_SET_FD_ORDER_ID; + PageIdList[1] = FORM_SET_HD_ORDER_ID; + PageIdList[2] = FORM_SET_CD_ORDER_ID; + PageIdList[3] = FORM_SET_NET_ORDER_ID; + PageIdList[4] = FORM_SET_BEV_ORDER_ID; OptionMenu = NULL; BbsType = 0; LegacyOrder = NULL; diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/Variable.c b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/Variable.c index 0e9dbda667..e4299ff6cb 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/Variable.c +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/Variable.c @@ -1113,6 +1113,7 @@ Var_UpdateDriverOrder ( is also updated. @param CallbackData The context data for BMM. + @param FormId The form id. @return EFI_SUCCESS The function completed successfully. @retval EFI_NOT_FOUND If VAR_LEGACY_DEV_ORDER and gEfiLegacyDevOrderVariableGuid EFI Variable can be found.