tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too 

It is possible to find variable entries with State being 0xff, i.e. not
updated since flash block erase.   This indicates the variable driver
could not complete the header write while appending a new entry, and
therefore State was not set to VAR_HEADER_VALID_ONLY.

This can only happen at the end of the variable list, so treat this as
additional "end of variable list" condition.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20240116171105.37831-6-kraxel@redhat.com>
This commit is contained in:
Gerd Hoffmann 2024-01-16 18:11:04 +01:00 committed by mergify[bot]
parent b25733c974
commit 735d0a5e2e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c
View File

@ -302,6 +302,11 @@ ValidateFvHeader (
break;
}
if (VarHeader->State == 0xff) {
DEBUG ((DEBUG_INFO, "%a: end of var list (unwritten state)\n", __func__));
break;
}
VarName = NULL;
switch (VarHeader->State) {
// usage: State = VAR_HEADER_VALID_ONLY