From 76d995948247309094c71880bffd913d78c05e66 Mon Sep 17 00:00:00 2001 From: xli24 Date: Thu, 23 Oct 2008 07:17:18 +0000 Subject: [PATCH] Update EBC sub-dir of BaseLib according to code review comments. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6198 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Library/BaseLib/Ebc/CpuBreakpoint.c | 9 +------ MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c | 26 +++++--------------- 2 files changed, 7 insertions(+), 28 deletions(-) diff --git a/MdePkg/Library/BaseLib/Ebc/CpuBreakpoint.c b/MdePkg/Library/BaseLib/Ebc/CpuBreakpoint.c index 77f4b2a7d2..837c204cf3 100644 --- a/MdePkg/Library/BaseLib/Ebc/CpuBreakpoint.c +++ b/MdePkg/Library/BaseLib/Ebc/CpuBreakpoint.c @@ -1,7 +1,7 @@ /** @file Base Library CPU Functions for EBC - Copyright (c) 2006, Intel Corporation
+ Copyright (c) 2006 - 2008, Intel Corporation
All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -54,8 +54,6 @@ MemoryFence ( /** Disables CPU interrupts. - Disables CPU interrupts. - **/ VOID EFIAPI @@ -69,8 +67,6 @@ DisableInterrupts ( /** Enables CPU interrupts. - Enables CPU interrupts. - **/ VOID EFIAPI @@ -105,9 +101,6 @@ GetInterruptState ( Enables CPU interrupts for the smallest window required to capture any pending interrupts. - Enables CPU interrupts for the smallest window required to capture any - pending interrupts. - **/ VOID EFIAPI diff --git a/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c b/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c index a57d534ae1..f2001393f0 100644 --- a/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c +++ b/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c @@ -1,7 +1,10 @@ /** @file - Switch Stack functions. + Implementation of SetJump() and LongJump() on EBC. + + SetJump() and LongJump() are not currently supported for the EBC processor type. + Implementation for EBC just returns 0 for SetJump(), and ASSERT() for LongJump(). - Copyright (c) 2006, Intel Corporation + Copyright (c) 2006 - 2008, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -14,23 +17,6 @@ #include -/** - Worker function that checks ASSERT condition for JumpBuffer - - Checks ASSERT condition for JumpBuffer. - - If JumpBuffer is NULL, then ASSERT(). - For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, then ASSERT(). - - @param JumpBuffer A pointer to CPU context buffer. - -**/ -VOID -EFIAPI -InternalAssertJumpBuffer ( - IN BASE_LIBRARY_JUMP_BUFFER *JumpBuffer - ); - /** Saves the current CPU context that can be restored with a call to LongJump() and returns 0. @@ -59,7 +45,7 @@ SetJump ( Restores the CPU context from the buffer specified by JumpBuffer. This function never returns to the caller. - Instead is resumes execution based on the state of JumpBuffer. + Instead it resumes execution based on the state of JumpBuffer. @param JumpBuffer A pointer to CPU context buffer. @param Value The value to return when the SetJump() context is restored.