Refine code to make it more safely.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>




git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15591 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Eric Dong 2014-06-25 06:49:53 +00:00 committed by ydong10
parent 1fee5304db
commit 79ecd2dbfa
3 changed files with 8 additions and 4 deletions

View File

@ -1,7 +1,7 @@
/** @file /** @file
Initialize Debug Agent in DXE by invoking Debug Agent Library. Initialize Debug Agent in DXE by invoking Debug Agent Library.
Copyright (c) 2013, Intel Corporation. All rights reserved.<BR> Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -58,6 +58,7 @@ DebugAgentDxeInitialize(
{ {
EFI_STATUS Status; EFI_STATUS Status;
Status = EFI_UNSUPPORTED;
InitializeDebugAgent (DEBUG_AGENT_INIT_DXE_LOAD, &Status, NULL); InitializeDebugAgent (DEBUG_AGENT_INIT_DXE_LOAD, &Status, NULL);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
return Status; return Status;
@ -95,6 +96,7 @@ DebugAgentDxeUnload (
{ {
EFI_STATUS Status; EFI_STATUS Status;
Status = EFI_UNSUPPORTED;
InitializeDebugAgent (DEBUG_AGENT_INIT_DXE_UNLOAD, &Status, NULL); InitializeDebugAgent (DEBUG_AGENT_INIT_DXE_UNLOAD, &Status, NULL);
return Status; return Status;

View File

@ -1,7 +1,7 @@
/** @file /** @file
Initialize Debug Agent in PEI by invoking Debug Agent Library. Initialize Debug Agent in PEI by invoking Debug Agent Library.
Copyright (c) 2013, Intel Corporation. All rights reserved.<BR> Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -39,6 +39,7 @@ DebugAgentPeiInitialize (
{ {
EFI_STATUS Status; EFI_STATUS Status;
Status = EFI_UNSUPPORTED;
InitializeDebugAgent (DEBUG_AGENT_INIT_PEI, &Status, NULL); InitializeDebugAgent (DEBUG_AGENT_INIT_PEI, &Status, NULL);
return Status; return Status;

View File

@ -587,7 +587,7 @@ ReadRemainingBreakPacket (
// //
// Has received start symbol, try to read the rest part // Has received start symbol, try to read the rest part
// //
if (DebugPortReadBuffer (Handle, &DebugHeader->Command, sizeof (DEBUG_PACKET_HEADER) - 1, READ_PACKET_TIMEOUT) == 0) { if (DebugPortReadBuffer (Handle, (UINT8 *)DebugHeader + OFFSET_OF (DEBUG_PACKET_HEADER, Command), sizeof (DEBUG_PACKET_HEADER) - OFFSET_OF (DEBUG_PACKET_HEADER, Command), READ_PACKET_TIMEOUT) == 0) {
// //
// Timeout occur, exit // Timeout occur, exit
// //
@ -1014,7 +1014,7 @@ ReceivePacket (
// //
Received = DebugPortReadBuffer ( Received = DebugPortReadBuffer (
Handle, Handle,
&DebugHeader->Command, (UINT8 *)DebugHeader + OFFSET_OF (DEBUG_PACKET_HEADER, Command),
OFFSET_OF (DEBUG_PACKET_HEADER, Length) + sizeof (DebugHeader->Length) - sizeof (DebugHeader->StartSymbol), OFFSET_OF (DEBUG_PACKET_HEADER, Length) + sizeof (DebugHeader->Length) - sizeof (DebugHeader->StartSymbol),
Timeout Timeout
); );
@ -2104,6 +2104,7 @@ InterruptProcess (
UINT32 IssuedViewPoint; UINT32 IssuedViewPoint;
DEBUG_AGENT_EXCEPTION_BUFFER *ExceptionBuffer; DEBUG_AGENT_EXCEPTION_BUFFER *ExceptionBuffer;
InputCharacter = 0;
ProcessorIndex = 0; ProcessorIndex = 0;
IssuedViewPoint = 0; IssuedViewPoint = 0;
BreakReceived = FALSE; BreakReceived = FALSE;