tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

The definition of NumberOfSmmReservedRegions is incorrect in Framework SmmCis specification 0.91, in which the type of this field is defined as UINTN. However, HOBs are supposed to be CPU neutral, so UINT32 should be used. Here the code is updated and comments in FrameworkSpecConformance.txt is added. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10813 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
xli24 2010-08-20 17:32:04 +00:00
parent 9e375eb11f
commit 7ae58ec2ea
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
IntelFrameworkPkg/FrameworkSpecConformance.txt
View File

@ -1119,13 +1119,18 @@
##
1. Include/Guid/SmramMemoryReserve.h
typedef struct {
UINT32 NumberOfSmmReservedRegions;
...
} EFI_SMRAM_HOB_DESCRIPTOR_BLOCK;
The name of the definition is *NOT* consistent with Framework SmmCis specification 0.91, in which it's
1) The name of the definition is *NOT* consistent with Framework SmmCis specification 0.91, in which it's
defined as "EFI_HOB_SMRAM_DESCRIPTOR_BLOCK" rather than "EFI_SMRAM_HOB_DESCRIPTOR_BLOCK".
Keeping this inconsistency for backward compatibility.
2) The definition of NumberOfSmmReservedRegions is *NOT* consistent with Framework SmmCis specification 0.91,
in which the type of this field is defined as UINTN. However, HOBs are supposed to be CPU neutral, so UINTN
is incorrect and UINT32 should be used.
2. Include/Guid/SmramMemoryReserve.h
typedef enum {
...

6
IntelFrameworkPkg/Include/Guid/SmramMemoryReserve.h
View File

@ -42,7 +42,11 @@ typedef struct {
/// Designates the number of possible regions in the system
/// that can be usable for SMRAM.
///
UINTN NumberOfSmmReservedRegions;
/// Inconsistent with specification here:
/// In Framework SMM CIS 0.91 specification, it defines the field type as UINTN.
/// However, HOBs are supposed to be CPU neutral, so UINT32 should be used instead.
///
UINT32 NumberOfSmmReservedRegions;
///
/// Used throughout this protocol to describe the candidate
/// regions for SMRAM that are supported by this platform.