tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-07 13:54:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check

Browse Source 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587

The Status check in "if (!EFI_ERROR (Status))" condition is useless,
it should be NULL pointer check. And this patch also fixes a typo
"continous" to "continuous".

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Star Zeng 2017-06-05 14:31:19 +08:00
parent 1a0ad70ee1
commit 7b5d848dbf
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
MdePkg/Library/SmmIoLib/SmmIoLib.c
View File

@ -156,7 +156,7 @@ SmmIsMmioValid (
} }
/** /**
Merge continous entries whose type is EfiGcdMemoryTypeMemoryMappedIo. Merge continuous entries whose type is EfiGcdMemoryTypeMemoryMappedIo.
@param[in, out] GcdMemoryMap A pointer to the buffer in which firmware places @param[in, out] GcdMemoryMap A pointer to the buffer in which firmware places
the current GCD memory map. the current GCD memory map.
@ -218,6 +218,7 @@ MergeGcdMmioEntry (
@param[in] Handle The handle on which the interface was installed. @param[in] Handle The handle on which the interface was installed.
@retval EFI_SUCCESS Notification runs successfully. @retval EFI_SUCCESS Notification runs successfully.
@retval EFI_OUT_OF_RESOURCES No enough resources to save GCD MMIO map.
**/ **/
EFI_STATUS EFI_STATUS
EFIAPI EFIAPI
@ -237,10 +238,10 @@ SmmIoLibInternalEndOfDxeNotify (
MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors); MergeGcdMmioEntry (MemSpaceMap, &NumberOfDescriptors);
mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap); mSmmIoLibGcdMemSpace = AllocateCopyPool (NumberOfDescriptors * sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR), MemSpaceMap);
ASSERT_EFI_ERROR (Status); ASSERT (mSmmIoLibGcdMemSpace != NULL);
if (EFI_ERROR (Status)) { if (mSmmIoLibGcdMemSpace == NULL) {
gBS->FreePool (MemSpaceMap); gBS->FreePool (MemSpaceMap);
return Status; return EFI_OUT_OF_RESOURCES;
} }
mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors; mSmmIoLibGcdMemNumberOfDesc = NumberOfDescriptors;