tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/S3SaveState: cast Position for S3BootScriptLib explicitly 

The BootScriptInsert() and BootScriptLabel() functions take the in/out
parameter "Position" as (EFI_S3_BOOT_SCRIPT_POSITION*), and pass it to
S3BootScriptMoveLastOpcode() and S3BootScriptLabel(), respectively.

The callees take the in/out parameter "Position" as (VOID**). Add explicit
casts for clarity.

There is no change in functionality.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
This commit is contained in:
Laszlo Ersek 2019-09-13 19:33:38 +02:00
parent f662f91cb2
commit 812e3bade6
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
View File

@ -810,7 +810,7 @@ BootScriptInsert (
}
if (!EFI_ERROR (Status)) {
Status = S3BootScriptMoveLastOpcode (BeforeOrAfter, Position);
Status = S3BootScriptMoveLastOpcode (BeforeOrAfter, (VOID **)Position);
}
return Status;
}
@ -851,7 +851,7 @@ BootScriptLabel (
IN CONST CHAR8 *Label
)
{
return S3BootScriptLabel (BeforeOrAfter, CreateIfNotFound, Position, Label);
return S3BootScriptLabel (BeforeOrAfter, CreateIfNotFound, (VOID **)Position, Label);
}
/**
Compare two positions in the boot script table and return their relative position.

4
MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
View File

@ -808,7 +808,7 @@ BootScriptInsert (
}
if (!EFI_ERROR (Status)) {
Status = S3BootScriptMoveLastOpcode (BeforeOrAfter, Position);
Status = S3BootScriptMoveLastOpcode (BeforeOrAfter, (VOID **)Position);
}
return Status;
}
@ -849,7 +849,7 @@ BootScriptLabel (
IN CONST CHAR8 *Label
)
{
return S3BootScriptLabel (BeforeOrAfter, CreateIfNotFound, Position, Label);
return S3BootScriptLabel (BeforeOrAfter, CreateIfNotFound, (VOID **)Position, Label);
}
/**
Compare two positions in the boot script table and return their relative position.