tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/Variable: Merge variable header + data update into one step 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4597

When creating a new variable, skip marking VAR_HEADER_VALID_ONLY so that
variable header + data update can be merged into one flash write. This
will greatly reduce the time taken for updating a variable and thus
increase performance. Removing VAR_HEADER_VALID_ONLY marking doesn't
have any function impact since it's not used by current code to detect
variable header + data corruption.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Gao Cheng <gao.cheng@intel.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
This commit is contained in:
Gao Cheng 2023-11-13 12:29:38 +08:00 committed by mergify[bot]
parent cdf36b1e36
commit 88580a79d4
1 changed files with 4 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
View File

@ -2168,11 +2168,9 @@ UpdateVariable (
if (!mVariableModuleGlobal->VariableGlobal.EmuNvMode) { if (!mVariableModuleGlobal->VariableGlobal.EmuNvMode) {
// //
// Four steps // Two steps
// 1. Write variable header // 1. Write variable header and data
// 2. Set variable state to header valid // 2. Set variable state to valid
// 3. Write variable data
// 4. Set variable state to valid
// //
// //
// Step 1: // Step 1:
@ -2183,7 +2181,7 @@ UpdateVariable (
TRUE, TRUE,
Fvb, Fvb,
mVariableModuleGlobal->NonVolatileLastVariableOffset, mVariableModuleGlobal->NonVolatileLastVariableOffset,
(UINT32)GetVariableHeaderSize (AuthFormat), (UINT32)VarSize,
(UINT8 *)NextVariable (UINT8 *)NextVariable
); );
@ -2194,41 +2192,6 @@ UpdateVariable (
// //
// Step 2: // Step 2:
// //
NextVariable->State = VAR_HEADER_VALID_ONLY;
Status = UpdateVariableStore (
&mVariableModuleGlobal->VariableGlobal,
FALSE,
TRUE,
Fvb,
mVariableModuleGlobal->NonVolatileLastVariableOffset + OFFSET_OF (VARIABLE_HEADER, State),
sizeof (UINT8),
&NextVariable->State
);
if (EFI_ERROR (Status)) {
goto Done;
}
//
// Step 3:
//
Status = UpdateVariableStore (
&mVariableModuleGlobal->VariableGlobal,
FALSE,
TRUE,
Fvb,
mVariableModuleGlobal->NonVolatileLastVariableOffset + GetVariableHeaderSize (AuthFormat),
(UINT32)(VarSize - GetVariableHeaderSize (AuthFormat)),
(UINT8 *)NextVariable + GetVariableHeaderSize (AuthFormat)
);
if (EFI_ERROR (Status)) {
goto Done;
}
//
// Step 4:
//
NextVariable->State = VAR_ADDED; NextVariable->State = VAR_ADDED;
Status = UpdateVariableStore ( Status = UpdateVariableStore (
&mVariableModuleGlobal->VariableGlobal, &mVariableModuleGlobal->VariableGlobal,