From 88a7d4aa30a42e1fee8c6eb6972bb1a9260103fc Mon Sep 17 00:00:00 2001 From: Pierre Gondois Date: Thu, 10 Dec 2020 13:09:30 +0000 Subject: [PATCH] ArmPkg: Fix Ecc error 5007 in SemihostFs This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c index 230f971f8b..6a06b38ab9 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -90,8 +90,9 @@ AllocateFCB ( VOID ) { - SEMIHOST_FCB *Fcb = AllocateZeroPool (sizeof (SEMIHOST_FCB)); + SEMIHOST_FCB *Fcb; + Fcb = AllocateZeroPool (sizeof (SEMIHOST_FCB)); if (Fcb != NULL) { CopyMem (&Fcb->File, &gSemihostFsFile, sizeof (gSemihostFsFile)); Fcb->Signature = SEMIHOST_FCB_SIGNATURE; @@ -122,7 +123,7 @@ VolumeOpen ( OUT EFI_FILE **Root ) { - SEMIHOST_FCB *RootFcb = NULL; + SEMIHOST_FCB *RootFcb; if (Root == NULL) { return EFI_INVALID_PARAMETER; @@ -759,12 +760,13 @@ GetFileInfo ( OUT VOID *Buffer ) { - EFI_FILE_INFO *Info = NULL; - UINTN NameSize = 0; + EFI_FILE_INFO *Info; + UINTN NameSize; UINTN ResultSize; UINTN Index; if (Fcb->IsRoot) { + NameSize = 0; ResultSize = SIZE_OF_EFI_FILE_INFO + sizeof(CHAR16); } else { NameSize = AsciiStrLen (Fcb->FileName) + 1;