tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.LineBuffer 

This field is (re)allocated in QemuVideoGraphicsOutputSetMode(), released
in QemuVideoGraphicsOutputDestructor(), and used for nothing else. Remove
it.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
This commit is contained in:
Laszlo Ersek 2016-10-12 10:38:49 +02:00
parent 37b9c0a656
commit 88ba362da7
2 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
OvmfPkg/QemuVideoDxe/Gop.c
View File

@ -167,15 +167,6 @@ Routine Description:
ModeData = &Private->ModeData[ModeNumber]; ModeData = &Private->ModeData[ModeNumber];
if (Private->LineBuffer) {
gBS->FreePool (Private->LineBuffer);
}
Private->LineBuffer = AllocatePool (4 * ModeData->HorizontalResolution);
if (Private->LineBuffer == NULL) {
return EFI_OUT_OF_RESOURCES;
}
switch (Private->Variant) { switch (Private->Variant) {
case QEMU_VIDEO_CIRRUS_5430: case QEMU_VIDEO_CIRRUS_5430:
case QEMU_VIDEO_CIRRUS_5446: case QEMU_VIDEO_CIRRUS_5446:
@ -187,8 +178,6 @@ Routine Description:
break; break;
default: default:
ASSERT (FALSE); ASSERT (FALSE);
gBS->FreePool (Private->LineBuffer);
Private->LineBuffer = NULL;
return EFI_DEVICE_ERROR; return EFI_DEVICE_ERROR;
} }
@ -349,7 +338,6 @@ QemuVideoGraphicsOutputConstructor (
} }
Private->GraphicsOutput.Mode->MaxMode = (UINT32) Private->MaxMode; Private->GraphicsOutput.Mode->MaxMode = (UINT32) Private->MaxMode;
Private->GraphicsOutput.Mode->Mode = GRAPHICS_OUTPUT_INVALIDE_MODE_NUMBER; Private->GraphicsOutput.Mode->Mode = GRAPHICS_OUTPUT_INVALIDE_MODE_NUMBER;
Private->LineBuffer = NULL;
Private->FrameBufferBltConfigure = NULL; Private->FrameBufferBltConfigure = NULL;
Private->FrameBufferBltConfigureSize = 0; Private->FrameBufferBltConfigureSize = 0;
@ -395,10 +383,6 @@ Returns:
--*/ --*/
{ {
if (Private->LineBuffer != NULL) {
FreePool (Private->LineBuffer);
}
if (Private->FrameBufferBltConfigure != NULL) { if (Private->FrameBufferBltConfigure != NULL) {
FreePool (Private->FrameBufferBltConfigure); FreePool (Private->FrameBufferBltConfigure);
} }

1
OvmfPkg/QemuVideoDxe/Qemu.h
View File

@ -116,7 +116,6 @@ typedef struct {
UINTN MaxMode; UINTN MaxMode;
QEMU_VIDEO_MODE_DATA *ModeData; QEMU_VIDEO_MODE_DATA *ModeData;
UINT8 *LineBuffer;
QEMU_VIDEO_VARIANT Variant; QEMU_VIDEO_VARIANT Variant;
FRAME_BUFFER_CONFIGURE *FrameBufferBltConfigure; FRAME_BUFFER_CONFIGURE *FrameBufferBltConfigure;
UINTN FrameBufferBltConfigureSize; UINTN FrameBufferBltConfigureSize;