SourceLevelDebugPkg: Fix calculate the checksum bug and add NULL pointer check

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>





git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17160 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Jeff Fan 2015-04-10 08:52:48 +00:00 committed by vanjeff
parent 1ae469b9ed
commit 8977a7b7b6
2 changed files with 5 additions and 1 deletions

View File

@ -381,7 +381,7 @@ UpdateMailboxContent (
Mailbox->HostSequenceNo = (UINT8) Value; Mailbox->HostSequenceNo = (UINT8) Value;
break; break;
case DEBUG_MAILBOX_DEBUG_TIMER_FREQUENCY: case DEBUG_MAILBOX_DEBUG_TIMER_FREQUENCY:
Mailbox->ToBeCheckSum = Mailbox->CheckSum + CalculateSum8 ((UINT8 *)&Mailbox->HostSequenceNo, sizeof(UINT32)) Mailbox->ToBeCheckSum = Mailbox->CheckSum + CalculateSum8 ((UINT8 *)&Mailbox->DebugTimerFrequency, sizeof(UINT32))
- CalculateSum8 ((UINT8 *)&Value, sizeof(UINT32)); - CalculateSum8 ((UINT8 *)&Value, sizeof(UINT32));
Mailbox->DebugTimerFrequency = (UINT32) Value; Mailbox->DebugTimerFrequency = (UINT32) Value;
break; break;

View File

@ -522,6 +522,10 @@ InitializeDebugAgent (
// Build mailbox in HOB and setup Mailbox Set In Pei flag // Build mailbox in HOB and setup Mailbox Set In Pei flag
// //
Mailbox = AllocateZeroPool (sizeof (DEBUG_AGENT_MAILBOX)); Mailbox = AllocateZeroPool (sizeof (DEBUG_AGENT_MAILBOX));
if (Mailbox == NULL) {
DEBUG ((EFI_D_ERROR, "DebugAgent: Failed to allocate memory!\n"));
CpuDeadLoop ();
}
MailboxLocation = (UINT64)(UINTN)Mailbox; MailboxLocation = (UINT64)(UINTN)Mailbox;
MailboxLocationPointer = BuildGuidDataHob ( MailboxLocationPointer = BuildGuidDataHob (
&gEfiDebugAgentGuid, &gEfiDebugAgentGuid,