From 8af71632d6552e637a2ce29c579c70ccc562ba7b Mon Sep 17 00:00:00 2001 From: Sudeep Holla Date: Wed, 23 Oct 2024 13:40:54 +0100 Subject: [PATCH] DynamicTablesPkg: Drop the unnecessary comparision of UINT8 max value Clang build breaks with the following error: | DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c:1441:20: | error: result of comparison of constant 256 with expression of type 'UINT8' | (aka 'unsigned char') is always false [-Werror,-Wtautological-constant-out-of-range-compare] | 1441 | (AccessSize > 256)) || | | ~~~~~~~~~~ ^ ~~~ | 1 error generated. AccessSize is UINT8 and the maximum value for UINT8 is 255, so the comparision is unnecessary. Drop the check to fix the build. Signed-off-by: Sudeep Holla --- .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c index 3db536dddf..bf0d7b0cca 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c @@ -1437,9 +1437,7 @@ AmlCodeGenRdRegister ( // Cf. ACPI 6.4, s14.7 Referencing the PCC address space // The AccessSize represents the Subspace Id for the PCC address space. - if (((AddressSpace == EFI_ACPI_6_4_PLATFORM_COMMUNICATION_CHANNEL) && - (AccessSize > 256)) || - ((AddressSpace != EFI_ACPI_6_4_PLATFORM_COMMUNICATION_CHANNEL) && + if (((AddressSpace != EFI_ACPI_6_4_PLATFORM_COMMUNICATION_CHANNEL) && (AccessSize > EFI_ACPI_6_4_QWORD)) || ((NameOpNode == NULL) && (NewRdNode == NULL))) {