tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-29 16:44:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

UefiCpuPkg/MpInitLib: MicrocodeData used but maybe uninitialized

Browse Source 
Cc: Feng Tian <feng.tian@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
This commit is contained in:
Jeff Fan 2016-08-19 10:32:30 +08:00
parent 1de28466b0
commit 8cce3c9a70
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
UefiCpuPkg/Library/MpInitLib/Microcode.c
View File

@ -92,6 +92,7 @@ MicrocodeDetect (
PlatformId = (UINT8) PlatformIdMsr.Bits.PlatformId; PlatformId = (UINT8) PlatformIdMsr.Bits.PlatformId;
LatestRevision = 0; LatestRevision = 0;
MicrocodeData = NULL;
MicrocodeEnd = (UINTN) (MicrocodePatchAddress + MicrocodePatchRegionSize); MicrocodeEnd = (UINTN) (MicrocodePatchAddress + MicrocodePatchRegionSize);
MicrocodeEntryPoint = (CPU_MICROCODE_HEADER *) (UINTN) MicrocodePatchAddress; MicrocodeEntryPoint = (CPU_MICROCODE_HEADER *) (UINTN) MicrocodePatchAddress;
do { do {
@ -198,6 +199,7 @@ MicrocodeDetect (
// Revision. A processor with no loaded update is considered to have a // Revision. A processor with no loaded update is considered to have a
// revision equal to zero. // revision equal to zero.
// //
ASSERT (MicrocodeData != NULL);
AsmWriteMsr64 ( AsmWriteMsr64 (
MSR_IA32_BIOS_UPDT_TRIG, MSR_IA32_BIOS_UPDT_TRIG,
(UINT64) (UINTN) MicrocodeData (UINT64) (UINTN) MicrocodeData