mirror of https://github.com/acidanthera/audk.git
OvmfPkg/PlatformBootManagerLib: process TPM PPI request
Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI requests from PlatformBootManagerAfterConsole(). Laszlo understanding of edk2 is that the PPI operation processing was meant to occur *entirely* before End-Of-Dxe, so that 3rd party UEFI drivers couldn't interfere with PPI opcode processing *at all*. He suggested that we should *not* call Tcg2PhysicalPresenceLibProcessRequest() from BeforeConsole(). Because, an "auth" console, i.e. one that does not depend on a 3rd party driver, is *in general* impossible to guarantee. Instead we could opt to trust 3rd party drivers, and use the "normal" console(s) in AfterConsole(), in order to let the user confirm the PPI requests. It will depend on the user to enable Secure Boot, so that the trustworthiness of those 3rd party drivers is ensured. If an attacker roots the guest OS from within, queues some TPM2 PPI requests, and also modifies drivers on the EFI system partition and/or in GPU option ROMs (?), then those drivers will not load after guest reboot, and thus the dependent console(s) won't be used for confirming the PPI requests. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
This commit is contained in:
parent
b9777bb42e
commit
8d65d3b25e
|
@ -16,6 +16,7 @@
|
|||
#include <Guid/XenInfo.h>
|
||||
#include <Guid/RootBridgesConnectedEventGroup.h>
|
||||
#include <Protocol/FirmwareVolume2.h>
|
||||
#include <Library/Tcg2PhysicalPresenceLib.h>
|
||||
|
||||
|
||||
//
|
||||
|
@ -1515,6 +1516,11 @@ PlatformBootManagerAfterConsole (
|
|||
//
|
||||
PciAcpiInitialization ();
|
||||
|
||||
//
|
||||
// Process TPM PPI request
|
||||
//
|
||||
Tcg2PhysicalPresenceLibProcessRequest (NULL);
|
||||
|
||||
//
|
||||
// Process QEMU's -kernel command line option
|
||||
//
|
||||
|
|
|
@ -38,6 +38,7 @@
|
|||
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
|
||||
SourceLevelDebugPkg/SourceLevelDebugPkg.dec
|
||||
OvmfPkg/OvmfPkg.dec
|
||||
SecurityPkg/SecurityPkg.dec
|
||||
|
||||
[LibraryClasses]
|
||||
BaseLib
|
||||
|
@ -56,6 +57,7 @@
|
|||
LoadLinuxLib
|
||||
QemuBootOrderLib
|
||||
UefiLib
|
||||
Tcg2PhysicalPresenceLib
|
||||
|
||||
[Pcd]
|
||||
gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent
|
||||
|
|
Loading…
Reference in New Issue