tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-25 14:44:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

RedfishDiscoverDxe: handle memory allocation error conditions.

Browse Source 
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4625

Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
This commit is contained in:
Mike Maslenkin 2023-12-14 01:33:55 +03:00 committed by mergify[bot]
parent 139887a989
commit 91f1ce4e27
1 changed files with 78 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
View File

@ -791,38 +791,105 @@ InitInformationData (
if (RedfishLocation != NULL) { if (RedfishLocation != NULL) {
AllocationSize = AsciiStrSize (RedfishLocation) * sizeof (CHAR16); AllocationSize = AsciiStrSize (RedfishLocation) * sizeof (CHAR16);
Information->Location = AllocatePool (AllocationSize); Information->Location = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, AllocationSize); if (Information->Location != NULL) {
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", Information->Location)); AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", Information->Location));
} else {
DEBUG ((
DEBUG_ERROR,
"%a: Can not allocate memory for Redfish service location: %a.\n",
__func__,
RedfishLocation
));
}
} }
if (Uuid != NULL) { if (Uuid != NULL) {
AllocationSize = AsciiStrSize (Uuid) * sizeof (CHAR16); AllocationSize = AsciiStrSize (Uuid) * sizeof (CHAR16);
Information->Uuid = AllocatePool (AllocationSize); Information->Uuid = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AllocationSize); if (Information->Uuid != NULL) {
DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information->Uuid)); AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information->Uuid));
} else {
DEBUG ((
DEBUG_ERROR,
"%a: Can not allocate memory for Service UUID: %a.\n",
__func__,
Uuid
));
}
} }
if (Os != NULL) { if (Os != NULL) {
AllocationSize = AsciiStrSize (Os) * sizeof (CHAR16); AllocationSize = AsciiStrSize (Os) * sizeof (CHAR16);
Information->Os = AllocatePool (AllocationSize); Information->Os = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (Os, Information->Os, AllocationSize); if (Information->Os != NULL) {
AsciiStrToUnicodeStrS (Os, Information->Os, AllocationSize);
} else {
DEBUG ((
DEBUG_ERROR,
"%a: Can not allocate memory for Redfish service OS: %a.\n",
__func__,
Os
));
}
} }
if (OsVer != NULL) { if (OsVer != NULL) {
AllocationSize = AsciiStrSize (OsVer) * sizeof (CHAR16); AllocationSize = AsciiStrSize (OsVer) * sizeof (CHAR16);
Information->OsVersion = AllocatePool (AllocationSize); Information->OsVersion = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AllocationSize); if (Information->OsVersion != NULL) {
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n", Information->Os, Information->OsVersion)); AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AllocationSize);
DEBUG ((
DEBUG_MANAGEABILITY,
"Redfish service OS: %s, Version:%s.\n",
Information->Os,
Information->OsVersion
));
} else {
DEBUG ((
DEBUG_ERROR,
"%a: Can not allocate memory for Redfish OS Version:%a.\n",
__func__,
OsVer
));
}
} }
if ((Product != NULL) && (ProductVer != NULL)) { if (Product != NULL) {
AllocationSize = AsciiStrSize (Product) * sizeof (CHAR16); AllocationSize = AsciiStrSize (Product) * sizeof (CHAR16);
Information->Product = AllocatePool (AllocationSize); Information->Product = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (Product, Information->Product, AllocationSize); if (Information->Product != NULL) {
AsciiStrToUnicodeStrS (Product, Information->Product, AllocationSize);
} else {
DEBUG ((
DEBUG_ERROR,
"%a: Can not allocate memory for Redfish service product: %a.\n",
__func__,
Product
));
}
}
if (ProductVer != NULL) {
AllocationSize = AsciiStrSize (ProductVer) * sizeof (CHAR16); AllocationSize = AsciiStrSize (ProductVer) * sizeof (CHAR16);
Information->ProductVer = AllocatePool (AllocationSize); Information->ProductVer = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, AllocationSize); if (Information->ProductVer != NULL) {
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, Version:%s.\n", Information->Product, Information->ProductVer)); AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, AllocationSize);
DEBUG ((
DEBUG_MANAGEABILITY,
"Redfish service product: %s, Version:%s.\n",
Information->Product,
Information->ProductVer
));
} else {
DEBUG ((
DEBUG_ERROR,
"%a: Can not allocate memory for Redfish service product Version: %a.\n",
__func__,
ProductVer
));
}
} }
} }