BaseUeImageLib: Refactored out unused code.

This commit is contained in:
Mikhail Krichanov 2023-09-29 11:49:40 +03:00 committed by MikhailKrichanov
parent e33395096c
commit 923004dd69
2 changed files with 20 additions and 35 deletions

View File

@ -27,8 +27,6 @@ struct UE_LOADER_RUNTIME_CONTEXT_ {
UINT64 *FixupData; UINT64 *FixupData;
UINT32 UnchainedRelocsSize; UINT32 UnchainedRelocsSize;
UINT8 *UnchainedRelocs; UINT8 *UnchainedRelocs;
UINT32 RelocTableSize;
UINT8 RelocTable[];
}; };
typedef union { typedef union {
@ -430,14 +428,11 @@ UeLoaderGetRuntimeContextSize (
{ {
ASSERT (Context != NULL); ASSERT (Context != NULL);
ASSERT (Size != NULL); ASSERT (Size != NULL);
//
// FIXME: Do we need bookkeeping? Can we prevent relocs to writable segments? *Size = sizeof (UE_LOADER_RUNTIME_CONTEXT);
//
*Size = sizeof (UE_LOADER_RUNTIME_CONTEXT) + Context->RelocTableSize;
return RETURN_SUCCESS; return RETURN_SUCCESS;
} }
// FIXME:!!!
/** /**
Apply an image relocation fixup. Apply an image relocation fixup.
@ -1078,14 +1073,6 @@ UeRelocateImage (
if (RuntimeContext != NULL) { if (RuntimeContext != NULL) {
RuntimeContext->Machine = Context->Machine; RuntimeContext->Machine = Context->Machine;
RuntimeContext->RelocTableSize = Context->RelocTableSize;
ASSERT (Context->RelocTableSize <= RuntimeContextSize - sizeof (*RuntimeContext));
CopyMem (
RuntimeContext->RelocTable,
Context->FileBuffer + Context->LoadTablesFileOffset,
Context->RelocTableSize
);
} }
return InternaRelocateImage ( return InternaRelocateImage (
@ -1112,7 +1099,6 @@ UeRelocateImageForRuntime (
{ {
ASSERT (RuntimeContext != NULL); ASSERT (RuntimeContext != NULL);
// FIXME: Relocs to writable segments?
return InternaRelocateImage ( return InternaRelocateImage (
Image, Image,
ImageSize, ImageSize,

View File

@ -39,9 +39,8 @@
[FixedPcd] [FixedPcd]
gEfiMdePkgTokenSpaceGuid.PcdImageLoaderAlignmentPolicy gEfiMdePkgTokenSpaceGuid.PcdImageLoaderAlignmentPolicy
gEfiMdePkgTokenSpaceGuid.PcdImageLoaderLoadHeader gEfiMdePkgTokenSpaceGuid.PcdImageLoaderLoadHeader
gEfiMdePkgTokenSpaceGuid.PcdImageLoaderRemoveXForWX
gEfiMdePkgTokenSpaceGuid.PcdDebugRaisePropertyMask gEfiMdePkgTokenSpaceGuid.PcdDebugRaisePropertyMask
gEfiMdePkgTokenSpaceGuid.PcdImageLoaderRemoveXForWX
gEfiMdePkgTokenSpaceGuid.PcdUefiImageFormatSupportNonFv gEfiMdePkgTokenSpaceGuid.PcdUefiImageFormatSupportNonFv
gEfiMdePkgTokenSpaceGuid.PcdUefiImageFormatSupportFv gEfiMdePkgTokenSpaceGuid.PcdUefiImageFormatSupportFv