tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-25 22:54:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add check for Zero Relocation section.

Browse Source 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7197 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
lgao4 2009-01-07 02:02:39 +00:00
parent a4f31dafa7
commit 9833a9bb6c
2 changed files with 54 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
MdePkg/Include/Library/PeCoffLib.h
View File

@ -319,9 +319,11 @@ PeCoffLoaderImageReadFromMemory (
Reapply fixups on a fixed up PE32/PE32+ image to allow virutal calling at EFI Reapply fixups on a fixed up PE32/PE32+ image to allow virutal calling at EFI
runtime. runtime.
PE_COFF_LOADER_IMAGE_CONTEXT.FixupData stores information needed to reapply This function reapplies relocation fixups to the PE/COFF image specified by ImageBase
the fixups with a virtual mapping. and ImageSize so the image will execute correctly when the PE/COFF image is mapped
to the address specified by VirtualImageBase. RelocationData must be identical
to the FiuxupData buffer from the PE_COFF_LOADER_IMAGE_CONTEXT structure
after this PE/COFF image was relocated with PeCoffLoaderRelocateImage().
@param ImageBase Base address of a PE/COFF image that has been loaded @param ImageBase Base address of a PE/COFF image that has been loaded
and relocated into system memory. and relocated into system memory.

80
MdePkg/Library/BasePeCoffLib/BasePeCoff.c
View File

@ -457,7 +457,7 @@ PeCoffLoaderGetImageInfo (
Converts an image address to the loaded address. Converts an image address to the loaded address.
@param ImageContext The context of the image being loaded. @param ImageContext The context of the image being loaded.
@param Address The address to be converted to the loaded address. @param Address The relative virtual address to be converted to the loaded address.
@return The converted address or NULL if the address can not be converted. @return The converted address or NULL if the address can not be converted.
@ -469,8 +469,7 @@ PeCoffLoaderImageAddress (
) )
{ {
// //
// @bug Check to make sure ImageSize is correct for the relocated image. // Make sure that Address and ImageSize is correct for the loaded image.
// it may only work for the file we start with and not the relocated image
// //
if (Address >= ImageContext->ImageSize) { if (Address >= ImageContext->ImageSize) {
ImageContext->ImageError = IMAGE_ERROR_INVALID_IMAGE_ADDRESS; ImageContext->ImageError = IMAGE_ERROR_INVALID_IMAGE_ADDRESS;
@ -586,17 +585,20 @@ PeCoffLoaderRelocateImage (
// the optional header to verify a desired directory entry is there. // the optional header to verify a desired directory entry is there.
// //
if (NumberOfRvaAndSizes > EFI_IMAGE_DIRECTORY_ENTRY_BASERELOC) { if ((NumberOfRvaAndSizes > EFI_IMAGE_DIRECTORY_ENTRY_BASERELOC) && (RelocDir->Size > 0)) {
RelocBase = PeCoffLoaderImageAddress (ImageContext, RelocDir->VirtualAddress); RelocBase = PeCoffLoaderImageAddress (ImageContext, RelocDir->VirtualAddress);
RelocBaseEnd = PeCoffLoaderImageAddress ( RelocBaseEnd = PeCoffLoaderImageAddress (
ImageContext, ImageContext,
RelocDir->VirtualAddress + RelocDir->Size - 1 RelocDir->VirtualAddress + RelocDir->Size - 1
); );
if (RelocBase == NULL || RelocBaseEnd == NULL) {
return RETURN_LOAD_ERROR;
}
} else { } else {
// //
// Set base and end to bypass processing below. // Set base and end to bypass processing below.
// //
RelocBase = RelocBaseEnd = 0; RelocBase = RelocBaseEnd = NULL;
} }
} else { } else {
Hdr.Te = (EFI_TE_IMAGE_HEADER *)(UINTN)(ImageContext->ImageAddress); Hdr.Te = (EFI_TE_IMAGE_HEADER *)(UINTN)(ImageContext->ImageAddress);
@ -607,13 +609,20 @@ PeCoffLoaderRelocateImage (
// Find the relocation block // Find the relocation block
// //
RelocDir = &Hdr.Te->DataDirectory[0]; RelocDir = &Hdr.Te->DataDirectory[0];
RelocBase = (EFI_IMAGE_BASE_RELOCATION *)(UINTN)( if (RelocDir->Size > 0) {
ImageContext->ImageAddress + RelocBase = (EFI_IMAGE_BASE_RELOCATION *)(UINTN)(
RelocDir->VirtualAddress + ImageContext->ImageAddress +
sizeof(EFI_TE_IMAGE_HEADER) - RelocDir->VirtualAddress +
Hdr.Te->StrippedSize sizeof(EFI_TE_IMAGE_HEADER) -
); Hdr.Te->StrippedSize
RelocBaseEnd = (EFI_IMAGE_BASE_RELOCATION *) ((UINTN) RelocBase + (UINTN) RelocDir->Size - 1); );
RelocBaseEnd = (EFI_IMAGE_BASE_RELOCATION *) ((UINTN) RelocBase + (UINTN) RelocDir->Size - 1);
} else {
//
// Set base and end to bypass processing below.
//
RelocBase = RelocBaseEnd = NULL;
}
} }
// //
@ -624,22 +633,28 @@ PeCoffLoaderRelocateImage (
Reloc = (UINT16 *) ((CHAR8 *) RelocBase + sizeof (EFI_IMAGE_BASE_RELOCATION)); Reloc = (UINT16 *) ((CHAR8 *) RelocBase + sizeof (EFI_IMAGE_BASE_RELOCATION));
RelocEnd = (UINT16 *) ((CHAR8 *) RelocBase + RelocBase->SizeOfBlock); RelocEnd = (UINT16 *) ((CHAR8 *) RelocBase + RelocBase->SizeOfBlock);
//
// Make sure RelocEnd is in the Image range.
//
if ((CHAR8 *) RelocEnd < (CHAR8 *)((UINTN) ImageContext->ImageAddress) ||
(CHAR8 *) RelocEnd > (CHAR8 *)((UINTN)ImageContext->ImageAddress + (UINTN)ImageContext->ImageSize)) {
ImageContext->ImageError = IMAGE_ERROR_FAILED_RELOCATION;
return RETURN_LOAD_ERROR;
}
if (!(ImageContext->IsTeImage)) { if (!(ImageContext->IsTeImage)) {
FixupBase = PeCoffLoaderImageAddress (ImageContext, RelocBase->VirtualAddress); FixupBase = PeCoffLoaderImageAddress (ImageContext, RelocBase->VirtualAddress);
if (FixupBase == NULL) {
return RETURN_LOAD_ERROR;
}
} else { } else {
FixupBase = (CHAR8 *)(UINTN)(ImageContext->ImageAddress + FixupBase = (CHAR8 *)(UINTN)(ImageContext->ImageAddress +
RelocBase->VirtualAddress + RelocBase->VirtualAddress +
sizeof(EFI_TE_IMAGE_HEADER) - sizeof(EFI_TE_IMAGE_HEADER) -
Hdr.Te->StrippedSize Hdr.Te->StrippedSize
); );
} }
if ((CHAR8 *) RelocEnd < (CHAR8 *) ((UINTN) ImageContext->ImageAddress) ||
(CHAR8 *) RelocEnd > (CHAR8 *)((UINTN)ImageContext->ImageAddress +
(UINTN)ImageContext->ImageSize)) {
ImageContext->ImageError = IMAGE_ERROR_FAILED_RELOCATION;
return RETURN_LOAD_ERROR;
}
// //
// Run this relocation record // Run this relocation record
@ -887,7 +902,6 @@ PeCoffLoaderLoadImage (
// //
Section = FirstSection; Section = FirstSection;
for (Index = 0, MaxEnd = NULL; Index < NumberOfSections; Index++) { for (Index = 0, MaxEnd = NULL; Index < NumberOfSections; Index++) {
// //
// Compute sections address // Compute sections address
// //
@ -896,6 +910,15 @@ PeCoffLoaderLoadImage (
ImageContext, ImageContext,
Section->VirtualAddress + Section->Misc.VirtualSize - 1 Section->VirtualAddress + Section->Misc.VirtualSize - 1
); );
//
// If the base start or end address resolved to 0, then fail.
//
if ((Base == NULL) || (End == NULL)) {
ImageContext->ImageError = IMAGE_ERROR_SECTION_NOT_LOADED;
return RETURN_LOAD_ERROR;
}
if (ImageContext->IsTeImage) { if (ImageContext->IsTeImage) {
Base = (CHAR8 *)((UINTN) Base + sizeof (EFI_TE_IMAGE_HEADER) - (UINTN)Hdr.Te->StrippedSize); Base = (CHAR8 *)((UINTN) Base + sizeof (EFI_TE_IMAGE_HEADER) - (UINTN)Hdr.Te->StrippedSize);
End = (CHAR8 *)((UINTN) End + sizeof (EFI_TE_IMAGE_HEADER) - (UINTN)Hdr.Te->StrippedSize); End = (CHAR8 *)((UINTN) End + sizeof (EFI_TE_IMAGE_HEADER) - (UINTN)Hdr.Te->StrippedSize);
@ -904,13 +927,6 @@ PeCoffLoaderLoadImage (
if (End > MaxEnd) { if (End > MaxEnd) {
MaxEnd = End; MaxEnd = End;
} }
//
// If the base start or end address resolved to 0, then fail.
//
if ((Base == NULL) || (End == NULL)) {
ImageContext->ImageError = IMAGE_ERROR_SECTION_NOT_LOADED;
return RETURN_LOAD_ERROR;
}
// //
// Read the section // Read the section
@ -1129,9 +1145,11 @@ PeCoffLoaderLoadImage (
Reapply fixups on a fixed up PE32/PE32+ image to allow virutal calling at EFI Reapply fixups on a fixed up PE32/PE32+ image to allow virutal calling at EFI
runtime. runtime.
PE_COFF_LOADER_IMAGE_CONTEXT.FixupData stores information needed to reapply This function reapplies relocation fixups to the PE/COFF image specified by ImageBase
the fixups with a virtual mapping. and ImageSize so the image will execute correctly when the PE/COFF image is mapped
to the address specified by VirtualImageBase. RelocationData must be identical
to the FiuxupData buffer from the PE_COFF_LOADER_IMAGE_CONTEXT structure
after this PE/COFF image was relocated with PeCoffLoaderRelocateImage().
@param ImageBase Base address of a PE/COFF image that has been loaded @param ImageBase Base address of a PE/COFF image that has been loaded
and relocated into system memory. and relocated into system memory.