tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast 

Sean reported that VS2019 build produce the following build error:
INFO - PvScsi.c
INFO - Generating code
INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): error C2220: the
       following warning is treated as an error
INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): warning C4244: '=':
       conversion from 'const UINT16' to 'UINT8', possible loss of data

This result from an implicit cast from PVSCSI Response->ScsiStatus
(Which is UINT16) to Packet->TargetResponse (Which is UINT8).

Fix this issue by adding an appropriate explicit cast and verify with
assert that this truncation do not result in loss of data.

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2651
Reported-by: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
Message-Id: <20200331110452.51992-1-liran.alon@oracle.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
[lersek@redhat.com: rewrap VS2019 diags in commit msg for PatchCheck.py]
This commit is contained in:
Liran Alon 2020-03-31 14:04:52 +03:00 committed by mergify[bot]
parent 335644f90f
commit 98936dc4f4
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
OvmfPkg/PvScsiDxe/PvScsi.c
View File

@ -455,8 +455,12 @@ HandleResponse (
//
// Report target status
// (Strangely, PVSCSI interface defines Response->ScsiStatus as UINT16.
// But it should de-facto always have a value that fits UINT8. To avoid
// unexpected behavior, verify value is in UINT8 bounds before casting)
//
Packet->TargetStatus = Response->ScsiStatus;
ASSERT (Response->ScsiStatus <= MAX_UINT8);
Packet->TargetStatus = (UINT8)Response->ScsiStatus;
//
// Host adapter status and function return value depend on