tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-25 22:54:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/PciSioSerialDxe: Do not flush the UART

Browse Source 
The patch aligns to the IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe
driver not flush the UART in Reset() and SetAttributes() function.
It was found the flush causes hang on certain PCI serial devices.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Eric Jin <eric.jin@intel.com>
This commit is contained in:
Ruiyu Ni 2016-05-09 11:21:25 +08:00
parent 09abc63675
commit 9c0dc0b01a
1 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
SerialIo implementation for PCI or SIO UARTs. SerialIo implementation for PCI or SIO UARTs.
Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -442,27 +442,6 @@ SerialReceiveTransmit (
return EFI_SUCCESS; return EFI_SUCCESS;
} }
/**
Flush the serial hardware transmit FIFO and shift register.
@param SerialDevice The device to flush.
**/
VOID
SerialFlushTransmitFifo (
SERIAL_DEV *SerialDevice
)
{
SERIAL_PORT_LSR Lsr;
//
// Wait for the serial port to be ready, to make sure both the transmit FIFO
// and shift register empty.
//
do {
Lsr.Data = READ_LSR (SerialDevice);
} while (Lsr.Bits.Temt == 0);
}
// //
// Interface Functions // Interface Functions
// //
@ -503,8 +482,6 @@ SerialReset (
Tpl = gBS->RaiseTPL (TPL_NOTIFY); Tpl = gBS->RaiseTPL (TPL_NOTIFY);
SerialFlushTransmitFifo (SerialDevice);
// //
// Make sure DLAB is 0. // Make sure DLAB is 0.
// //
@ -683,8 +660,6 @@ SerialSetAttributes (
Tpl = gBS->RaiseTPL (TPL_NOTIFY); Tpl = gBS->RaiseTPL (TPL_NOTIFY);
SerialFlushTransmitFifo (SerialDevice);
// //
// Put serial port on Divisor Latch Mode // Put serial port on Divisor Latch Mode
// //