mirror of https://github.com/acidanthera/audk.git
Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()
There is an inconsistency between the UNIX and Windows implementations of EMU_THUNK_PROTOCOL.SetTime(). The Windows version returns an EFI_STATUS value whereas the the UNIX implementation is VOID. However, the UNIX implementation is an unimplemented stub whereas the Windows version is implementated. The current EMU_THUNK_PROTOCOL function pointer definition specifies a VOID return type. However, EMU_THUNK_PROTOCOL.SetTime() is close to the spec defined gRT->SetTime() except for missing the EFI_STATUS return type. Therefore, I conclude that the most sensible reconciliation is to add the EFI_STATUS return type to the protocol definition. Cc: Andrew Fish <afish@apple.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
This commit is contained in:
parent
5a2490df0e
commit
9cf1d03ebe
|
@ -2,6 +2,7 @@
|
||||||
Emulator Thunk to abstract OS services from pure EFI code
|
Emulator Thunk to abstract OS services from pure EFI code
|
||||||
|
|
||||||
Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.<BR>
|
Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.<BR>
|
||||||
|
Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
|
||||||
|
|
||||||
SPDX-License-Identifier: BSD-2-Clause-Patent
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
||||||
|
|
||||||
|
@ -148,12 +149,12 @@ VOID
|
||||||
typedef
|
typedef
|
||||||
VOID
|
VOID
|
||||||
(EFIAPI *EMU_GET_TIME)(
|
(EFIAPI *EMU_GET_TIME)(
|
||||||
OUT EFI_TIME *Time,
|
OUT EFI_TIME *Time,
|
||||||
OUT EFI_TIME_CAPABILITIES *Capabilities OPTIONAL
|
OUT EFI_TIME_CAPABILITIES *Capabilities OPTIONAL
|
||||||
);
|
);
|
||||||
|
|
||||||
typedef
|
typedef
|
||||||
VOID
|
EFI_STATUS
|
||||||
(EFIAPI *EMU_SET_TIME)(
|
(EFIAPI *EMU_SET_TIME)(
|
||||||
IN EFI_TIME *Time
|
IN EFI_TIME *Time
|
||||||
);
|
);
|
||||||
|
|
|
@ -387,14 +387,14 @@ SecGetTime (
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
VOID
|
EFI_STATUS
|
||||||
SecSetTime (
|
SecSetTime (
|
||||||
IN EFI_TIME *Time
|
IN EFI_TIME *Time
|
||||||
)
|
)
|
||||||
{
|
{
|
||||||
// Don't change the time on the system
|
// Don't change the time on the system
|
||||||
// We could save delta to localtime() and have SecGetTime adjust return values?
|
// We could save delta to localtime() and have SecGetTime adjust return values?
|
||||||
return;
|
return EFI_UNSUPPORTED;
|
||||||
}
|
}
|
||||||
|
|
||||||
EFI_STATUS
|
EFI_STATUS
|
||||||
|
|
Loading…
Reference in New Issue