tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/BMMUI: Remove the incorrect and useless codes 

When updating console page, the "ConsoleCheck" in BmmFakeNvData may maintain
the old uncommitted data, we should not copy it to BmmOldFakeNVData.
And in BootMaintRouteConfig function, when save data successfully,
it will copy the BmmFakeNvData to the BmmOldFakeNVData.
So we can delete the logic here.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
This commit is contained in:
Dandan Bi 2016-10-17 13:51:05 +08:00 committed by Star Zeng
parent a3475fe0de
commit 9ec24f5f73
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c
View File

@ -459,8 +459,6 @@ UpdateConsolePage (
UINT16 Index2;
UINT8 CheckFlags;
UINT8 *ConsoleCheck;
UINT8 *OldConsoleCheck;
UINTN ConsoleCheckSize;
EFI_QUESTION_ID QuestionIdBase;
UINT16 VariableOffsetBase;
@ -469,32 +467,24 @@ UpdateConsolePage (
UpdatePageStart (CallbackData);
ConsoleCheck = NULL;
OldConsoleCheck = NULL;
QuestionIdBase = 0;
VariableOffsetBase = 0;
ConsoleCheckSize = 0;
switch (UpdatePageId) {
case FORM_CON_IN_ID:
ConsoleCheck = &CallbackData->BmmFakeNvData.ConsoleInCheck[0];
OldConsoleCheck = &CallbackData->BmmOldFakeNVData.ConsoleInCheck[0];
ConsoleCheckSize = sizeof (CallbackData->BmmFakeNvData.ConsoleInCheck);
QuestionIdBase = CON_IN_DEVICE_QUESTION_ID;
VariableOffsetBase = CON_IN_DEVICE_VAR_OFFSET;
break;
case FORM_CON_OUT_ID:
ConsoleCheck = &CallbackData->BmmFakeNvData.ConsoleOutCheck[0];
OldConsoleCheck = &CallbackData->BmmOldFakeNVData.ConsoleOutCheck[0];
ConsoleCheckSize = sizeof (CallbackData->BmmFakeNvData.ConsoleOutCheck);
QuestionIdBase = CON_OUT_DEVICE_QUESTION_ID;
VariableOffsetBase = CON_OUT_DEVICE_VAR_OFFSET;
break;
case FORM_CON_ERR_ID:
ConsoleCheck = &CallbackData->BmmFakeNvData.ConsoleErrCheck[0];
OldConsoleCheck = &CallbackData->BmmOldFakeNVData.ConsoleErrCheck[0];
ConsoleCheckSize = sizeof (CallbackData->BmmFakeNvData.ConsoleErrCheck);
QuestionIdBase = CON_ERR_DEVICE_QUESTION_ID;
VariableOffsetBase = CON_ERR_DEVICE_VAR_OFFSET;
break;
@ -556,8 +546,6 @@ UpdateConsolePage (
Index++;
}
CopyMem (OldConsoleCheck, ConsoleCheck, ConsoleCheckSize);
UpdatePageEnd (CallbackData);
}