From a1eff44b5ef7ef4cd96ecc54960dcfb18a455fb8 Mon Sep 17 00:00:00 2001 From: jljusten Date: Wed, 12 Sep 2012 07:18:50 +0000 Subject: [PATCH] OvmfPkg: fix the mask for accessing the PIIX4 PMBA [15:6] bitfield The Index Register Base Address bitfield is selected by the binary mask 00000000 00000000 11111111 11000000, 0xFFC0; fix the typo. Reported-by: Gleb Natapov Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13720 6f19259b-4bc3-4df7-8a09-765794883524 --- OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +- OvmfPkg/PlatformPei/Platform.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c b/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c index 027912e0f7..8f4a5b3d1e 100644 --- a/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c +++ b/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c @@ -60,7 +60,7 @@ AcpiTimerLibConstructor ( mPmba = PcdGet16 (PcdAcpiPmBaseAddress); PciAndThenOr32 (PCI_LIB_ADDRESS (0,Device,3,0x40), - (UINT32) ~0xfc0, mPmba); + (UINT32) ~0xFFC0, mPmba); PciOr8 (PCI_LIB_ADDRESS (0,Device,3,0x04), 0x01); } diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c index d91f113693..589c5c3804 100644 --- a/OvmfPkg/PlatformPei/Platform.c +++ b/OvmfPkg/PlatformPei/Platform.c @@ -230,7 +230,7 @@ MiscInitialization ( // // Set the PM I/O base address to 0x400 // - PciAndThenOr32 (PCI_LIB_ADDRESS (0, 1, 3, 0x40), (UINT32) ~0xfc0, 0x400); + PciAndThenOr32 (PCI_LIB_ADDRESS (0, 1, 3, 0x40), (UINT32) ~0xFFC0, 0x400); } }