tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/Qemu: Fix various typos 

Fix various typos in comments and documentation.

When "VbeShim.asm" is modified, we have to re-run "VbeShim.sh"
to update "VbeShim.h".
The string modified by this patch is only used when the DEBUG
macro (at the top of the file) is commented out. Since the
string is not referenced, NASM eliminates it, resulting in
the same byte array content in "VbeShim.h".

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Antoine Coeur <coeur@gmx.fr>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
Message-Id: <20200207010831.9046-58-philmd@redhat.com>
This commit is contained in:
Antoine Coeur 2020-02-07 02:08:10 +01:00 committed by mergify[bot]
parent f6fc95c943
commit a2e7559576
11 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
OvmfPkg/AcpiPlatformDxe/Qemu.c
View File

@ -137,7 +137,7 @@ QemuInstallAcpiMadtTable (
++Iso; ++Iso;
// //
// Set Level-tiggered, Active High for all possible PCI link targets. // Set Level-triggered, Active High for all possible PCI link targets.
// //
for (Loop = 0; Loop < 16; ++Loop) { for (Loop = 0; Loop < 16; ++Loop) {
if ((PcdGet16 (Pcd8259LegacyModeEdgeLevel) & (1 << Loop)) == 0) { if ((PcdGet16 (Pcd8259LegacyModeEdgeLevel) & (1 << Loop)) == 0) {
@ -148,7 +148,7 @@ QemuInstallAcpiMadtTable (
Iso->Bus = 0x00; // ISA Iso->Bus = 0x00; // ISA
Iso->Source = (UINT8) Loop; Iso->Source = (UINT8) Loop;
Iso->GlobalSystemInterruptVector = (UINT32) Loop; Iso->GlobalSystemInterruptVector = (UINT32) Loop;
Iso->Flags = 0x000D; // Level-tiggered, Active High Iso->Flags = 0x000D; // Level-triggered, Active High
++Iso; ++Iso;
} }
ASSERT ( ASSERT (

2
OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
View File

@ -1113,7 +1113,7 @@ InstallQemuFwCfgTables (
goto UninstallAcpiTables; goto UninstallAcpiTables;
} }
// //
// Ownership of S3Context has been transfered. // Ownership of S3Context has been transferred.
// //
S3Context = NULL; S3Context = NULL;
} }

4
OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
View File

@ -1156,7 +1156,7 @@ PciBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read returned. When possible 32-bit PCI configuration read cycles are used to read
from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range. end of the range.
@ -1193,7 +1193,7 @@ PciReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to returned. When possible 32-bit PCI configuration write cycles are used to
write from StartAdress to StartAddress + Size. Due to alignment restrictions, write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning 8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range. and the end of the range.

2
OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c
View File

@ -412,7 +412,7 @@ typedef struct {
If the call doesn't succeed, the contents of this If the call doesn't succeed, the contents of this
structure is indeterminate. structure is indeterminate.
@param[out] IsFinal In case of successul parsing, this parameter signals @param[out] IsFinal In case of successful parsing, this parameter signals
whether the node just parsed is the final node in the whether the node just parsed is the final node in the
device path. The call after a final node will attempt device path. The call after a final node will attempt
to start parsing the next path. If the call doesn't to start parsing the next path. If the call doesn't

2
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c
View File

@ -164,7 +164,7 @@ AllocFwCfgDmaAccessBuffer (
// //
// As per UEFI spec, in order to map a host address with // As per UEFI spec, in order to map a host address with
// BusMasterCommomBuffer64, the buffer must be allocated using the IOMMU // BusMasterCommonBuffer64, the buffer must be allocated using the IOMMU
// AllocateBuffer() // AllocateBuffer()
// //
Status = mIoMmuProtocol->AllocateBuffer ( Status = mIoMmuProtocol->AllocateBuffer (

4
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c
View File

@ -21,7 +21,7 @@
#include <Pi/PiFirmwareVolume.h> #include <Pi/PiFirmwareVolume.h>
// //
// The protocols, PPI and GUID defintions for this module // The protocols, PPI and GUID definitions for this module
// //
#include <Guid/SystemNvDataGuid.h> #include <Guid/SystemNvDataGuid.h>
// //
@ -41,7 +41,7 @@ typedef struct {
EFI_FVB_MEDIA_INFO mPlatformFvbMediaInfo[] = { EFI_FVB_MEDIA_INFO mPlatformFvbMediaInfo[] = {
// //
// Systen NvStorage FVB // System NvStorage FVB
// //
{ {
FixedPcdGet32 (PcdFlashNvStorageVariableSize) + FixedPcdGet32 (PcdFlashNvStorageVariableSize) +

4
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
View File

@ -1,8 +1,8 @@
## @file ## @file
# Component description file for QEMU Flash Fimware Volume Block DXE driver # Component description file for QEMU Flash Firmware Volume Block DXE driver
# module. # module.
# #
# This DXE runtime driver implements and produces the Fimware Volue Block # This DXE runtime driver implements and produces the Firmware Volue Block
# Protocol for a QEMU flash device. # Protocol for a QEMU flash device.
# #
# Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR> # Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>

4
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
View File

@ -1,8 +1,8 @@
## @file ## @file
# Component description file for QEMU Flash Fimware Volume Block SMM driver # Component description file for QEMU Flash Firmware Volume Block SMM driver
# module. # module.
# #
# This SMM driver implements and produces the SMM Fimware Volue Block Protocol # This SMM driver implements and produces the SMM Firmware Volue Block Protocol
# for a QEMU flash device. # for a QEMU flash device.
# #
# Copyright (C) 2015, Red Hat, Inc. # Copyright (C) 2015, Red Hat, Inc.

8
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
View File

@ -15,7 +15,7 @@
**/ **/
// //
// The protocols, PPI and GUID defintions for this module // The protocols, PPI and GUID definitions for this module
// //
#include <Protocol/DevicePath.h> #include <Protocol/DevicePath.h>
#include <Protocol/FirmwareVolumeBlock.h> #include <Protocol/FirmwareVolumeBlock.h>
@ -118,7 +118,7 @@ GetFvbInstance (
returned returned
Global - Pointer to ESAL_FWB_GLOBAL that contains all Global - Pointer to ESAL_FWB_GLOBAL that contains all
instance data instance data
FwhInstance - The EFI_FW_VOL_INSTANCE fimrware instance structure FwhInstance - The EFI_FW_VOL_INSTANCE firmware instance structure
Returns: Returns:
EFI_SUCCESS - Successfully returns EFI_SUCCESS - Successfully returns
@ -695,7 +695,7 @@ FvbProtocolWrite (
Writes data beginning at Lba:Offset from FV. The write terminates either Writes data beginning at Lba:Offset from FV. The write terminates either
when *NumBytes of data have been written, or when a block boundary is when *NumBytes of data have been written, or when a block boundary is
reached. *NumBytes is updated to reflect the actual number of bytes reached. *NumBytes is updated to reflect the actual number of bytes
written. The write opertion does not include erase. This routine will written. The write operation does not include erase. This routine will
attempt to write only the specified bytes. If the writes do not stick, attempt to write only the specified bytes. If the writes do not stick,
it will return an error. it will return an error.
@ -740,7 +740,7 @@ FvbProtocolRead (
Reads data beginning at Lba:Offset from FV. The Read terminates either Reads data beginning at Lba:Offset from FV. The Read terminates either
when *NumBytes of data have been read, or when a block boundary is when *NumBytes of data have been read, or when a block boundary is
reached. *NumBytes is updated to reflect the actual number of bytes reached. *NumBytes is updated to reflect the actual number of bytes
written. The write opertion does not include erase. This routine will written. The write operation does not include erase. This routine will
attempt to write only the specified bytes. If the writes do not stick, attempt to write only the specified bytes. If the writes do not stick,
it will return an error. it will return an error.

2
OvmfPkg/QemuVideoDxe/Driver.c
View File

@ -206,7 +206,7 @@ QemuVideoControllerDriverStart (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK); OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
// //
// Allocate Private context data for GOP inteface. // Allocate Private context data for GOP interface.
// //
Private = AllocateZeroPool (sizeof (QEMU_VIDEO_PRIVATE_DATA)); Private = AllocateZeroPool (sizeof (QEMU_VIDEO_PRIVATE_DATA));
if (Private == NULL) { if (Private == NULL) {

14
OvmfPkg/QemuVideoDxe/VbeShim.asm
View File

@ -49,7 +49,7 @@ Handler:
je ReadEdid je ReadEdid
cmp ah, 0x00 cmp ah, 0x00
je SetModeLegacy je SetModeLegacy
DebugLog StrUnkownFunction DebugLog StrUnknownFunction
Hang: Hang:
jmp Hang jmp Hang
@ -93,7 +93,7 @@ GetModeInfo:
and cx, ~0x4000 ; clear potentially set LFB bit in mode number and cx, ~0x4000 ; clear potentially set LFB bit in mode number
cmp cx, 0x00f1 cmp cx, 0x00f1
je KnownMode1 je KnownMode1
DebugLog StrUnkownMode DebugLog StrUnknownMode
jmp Hang jmp Hang
KnownMode1: KnownMode1:
; target (es:di) set on input ; target (es:di) set on input
@ -155,7 +155,7 @@ SetMode:
cmp bx, 0x40f1 cmp bx, 0x40f1
je KnownMode2 je KnownMode2
DebugLog StrUnkownMode DebugLog StrUnknownMode
jmp Hang jmp Hang
KnownMode2: KnownMode2:
@ -203,7 +203,7 @@ SetModeLegacy:
je KnownMode3 je KnownMode3
cmp al, 0x12 cmp al, 0x12
je KnownMode4 je KnownMode4
DebugLog StrUnkownMode DebugLog StrUnknownMode
jmp Hang jmp Hang
KnownMode3: KnownMode3:
mov al, 0x30 mov al, 0x30
@ -252,7 +252,7 @@ StrExitSuccess:
StrExitUnsupported: StrExitUnsupported:
db 'Unsupported', 0x0a, 0 db 'Unsupported', 0x0a, 0
StrUnkownFunction: StrUnknownFunction:
db 'Unknown Function', 0x0a, 0 db 'Unknown Function', 0x0a, 0
StrEnterGetInfo: StrEnterGetInfo:
@ -270,8 +270,8 @@ StrEnterSetMode:
StrEnterSetModeLegacy: StrEnterSetModeLegacy:
db 'SetModeLegacy', 0x0a, 0 db 'SetModeLegacy', 0x0a, 0
StrUnkownMode: StrUnknownMode:
db 'Unkown Mode', 0x0a, 0 db 'Unknown Mode', 0x0a, 0
StrGetPmCapabilities: StrGetPmCapabilities:
db 'GetPmCapabilities', 0x0a, 0 db 'GetPmCapabilities', 0x0a, 0