From a347b0897384a2af6605bdd19a7740972b73f1e7 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Sat, 31 Mar 2018 22:25:15 +0200 Subject: [PATCH] CryptoPkg/TlsLib: sanitize lib classes in internal header and INF "InternalTlsLib.h" includes "BaseCryptLib.h", but the lib class is not listed in the INF file. The INF file lists a good number of lib classes, but none of the lib class headers are included by "InternalTlsLib.h". Synchronize & sort both lists, while removing those library classes that aren't actually needed. (IntrinsicLib and OpensslLib have no edk2 class headers.) Cc: Jiaxin Wu Cc: Qin Long Cc: Siyuan Fu Cc: Ting Ye Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=915 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Long Qin Reviewed-by: Jiaxin Wu --- CryptoPkg/Library/TlsLib/InternalTlsLib.h | 3 +++ CryptoPkg/Library/TlsLib/TlsLib.inf | 6 ++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/InternalTlsLib.h b/CryptoPkg/Library/TlsLib/InternalTlsLib.h index 88c4e3b38e..3f18a461a8 100644 --- a/CryptoPkg/Library/TlsLib/InternalTlsLib.h +++ b/CryptoPkg/Library/TlsLib/InternalTlsLib.h @@ -19,6 +19,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #undef _WIN64 #include +#include +#include +#include #include #include #include diff --git a/CryptoPkg/Library/TlsLib/TlsLib.inf b/CryptoPkg/Library/TlsLib/TlsLib.inf index a3f93e7165..ae17a7d874 100644 --- a/CryptoPkg/Library/TlsLib/TlsLib.inf +++ b/CryptoPkg/Library/TlsLib/TlsLib.inf @@ -39,14 +39,12 @@ CryptoPkg/CryptoPkg.dec [LibraryClasses] + BaseCryptLib BaseLib BaseMemoryLib - MemoryAllocationLib - UefiRuntimeServicesTableLib DebugLib - OpensslLib IntrinsicLib - PrintLib + OpensslLib [BuildOptions] #