tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-04-08 17:05:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

EmbeddedPkg: CodeQL Fixes.

Browse Source 
Makes changes to comply with alerts raised by CodeQL.

Most of the issues here fall into the following two categories:

1. Potential use of uninitialized pointer.
2. Inconsistent integer width in comparison.

Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Co-authored-by: Ken Lautner <kenlautner3@gmail.com>
Co-authored-by: Bret Barkelew <bret@corthon.com>
Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
This commit is contained in:
Vineel Kovvuri[MSFT] 2024-10-25 16:37:01 -07:00 committed by mergify[bot]
parent d6f828b384
commit aae044a130
3 changed files with 7 additions and 1 deletions
EmbeddedPkg
Library
PrePiHobLib
Hob.c
PrePiLib
FwVol.c
SimpleTextInOutSerial
SimpleTextInOut.c

3
EmbeddedPkg/Library/PrePiHobLib/Hob.c

@ -498,6 +498,9 @@ BuildGuidDataHob (
ASSERT (Data != NULL || DataLength == 0);
HobData = BuildGuidHob (Guid, DataLength);
if (HobData == NULL) {
return NULL;
}
return CopyMem (HobData, Data, DataLength);
}

2
EmbeddedPkg/Library/PrePiLib/FwVol.c

@ -283,7 +283,7 @@ FfsProcessSection (
{
EFI_STATUS Status;
UINT32 SectionLength;
UINT32 ParsedLength;
UINTN ParsedLength;
EFI_COMPRESSION_SECTION *CompressionSection;
EFI_COMPRESSION_SECTION2 *CompressionSection2;
UINT32 DstBufferSize;

3
EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c

@ -504,6 +504,9 @@ OutputString (
Size = StrLen (String) + 1;
OutputString = AllocatePool (Size);
if (OutputString == NULL) {
return EFI_OUT_OF_RESOURCES;
}
// If there is any non-ascii characters in String buffer then replace it with '?'
// Eventually, UnicodeStrToAsciiStr API should be fixed.