tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-25 06:34:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

NetworkPkg/Ip6Dxe: Fix the potential NULL pointer free

Browse Source 
Ip6ConfigSetDnsServer may cause ASSERT if the invalid DNS
server address received. The issue is triggered by the NULL
pointer(Tmp) free.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
This commit is contained in:
Jiaxin Wu 2017-01-03 11:27:38 +08:00
parent d52f9163de
commit ab50ab6ea1
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
The implementation of EFI IPv6 Configuration Protocol. The implementation of EFI IPv6 Configuration Protocol.
Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR> Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -1366,13 +1366,17 @@ Ip6ConfigSetDnsServer (
// //
// The dns server address must be unicast. // The dns server address must be unicast.
// //
FreePool (Tmp); if (Tmp != NULL) {
FreePool (Tmp);
}
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
for (Index1 = NewIndex + 1; Index1 < NewDnsCount; Index1++) { for (Index1 = NewIndex + 1; Index1 < NewDnsCount; Index1++) {
if (EFI_IP6_EQUAL (NewDns + NewIndex, NewDns + Index1)) { if (EFI_IP6_EQUAL (NewDns + NewIndex, NewDns + Index1)) {
FreePool (Tmp); if (Tmp != NULL) {
FreePool (Tmp);
}
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
} }
} }