From ae79efb7bd436068156605ae7111b93dab710546 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Thu, 1 Oct 2020 19:37:10 +0100 Subject: [PATCH] MdePkg/BaseLib: use normal register init in ARM SetJump implementations There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readable mov r0, #0 instead. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Reviewed-by: Sami Mujawar --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S index e4c1946a28..e913202522 100644 --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S @@ -33,7 +33,7 @@ GCC_ASM_EXPORT(InternalLongJump) ASM_PFX(SetJump): mov r3, r13 stmia r0, {r3-r12,r14} - eor r0, r0, r0 + mov r0, #0 bx lr #/** diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm index e1eff758f7..ef02d85e0e 100644 --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm @@ -33,7 +33,7 @@ SetJump MOV R3, R13 STM R0, {R3-R12,R14} - EOR R0, R0 + MOV RO, #0 BX LR ;/**