tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add parameter check logic to clean up Klocwork warning. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7390 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
eric_tian 2009-02-02 05:50:45 +00:00
parent 6041576eb2
commit af58e37731
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
MdeModulePkg/Bus/Pci/UhciDxe/Uhci.c
View File

@ -633,6 +633,7 @@ Uhci2ControlTransfer (
UINT8 *DataPhy;
VOID *DataMap;
BOOLEAN IsSlowDevice;
UINTN TransferDataLength;
Uhc = UHC_FROM_USB2_HC_PROTO (This);
TDs = NULL;
@ -660,10 +661,16 @@ Uhci2ControlTransfer (
return EFI_INVALID_PARAMETER;
}
if ((TransferDirection != EfiUsbNoData) && (DataLength == NULL)) {
if ((TransferDirection != EfiUsbNoData) && (Data == NULL || DataLength == NULL)) {
return EFI_INVALID_PARAMETER;
}
if (TransferDirection == EfiUsbNoData) {
TransferDataLength = 0;
} else {
TransferDataLength = *DataLength;
}
*TransferResult = EFI_USB_ERR_SYSTEM;
Status = EFI_DEVICE_ERROR;
@ -702,7 +709,7 @@ Uhci2ControlTransfer (
PktId,
RequestPhy,
DataPhy,
*DataLength,
TransferDataLength,
(UINT8) MaximumPacketLength,
IsSlowDevice
);