mirror of https://github.com/acidanthera/audk.git
BaseTools: Fix crash in ECC when parsing incorrect header
The ECC tool crashes if a C file has an incorrect file header format. The file ArmPkg\Library\ArmMmuLib\AArch64\ArmMmuPeiLibConstructor.c has a file header in the incorrect format. It uses # to mark the header comments instead of enclosing the file header in /* */. This may have been a result of an INF file header being copied to a C file. A separate patch fixes the C file but ECC tool should not crash if a file with an incorrect header is found. Therefore, update the ECC tool to prevent it from crashing if an incorrect file header is found. With this change the ECC tool will report the incorrect header issue without crashing. Signed-off-by: Sami Mujawar <sami.mujawar@arm.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
This commit is contained in:
parent
35ed29f207
commit
b23c5b9722
|
@ -2,6 +2,7 @@
|
|||
# This file is used to be the c coding style checking of ECC tool
|
||||
#
|
||||
# Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
|
||||
# Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
|
||||
# SPDX-License-Identifier: BSD-2-Clause-Patent
|
||||
#
|
||||
|
||||
|
@ -64,7 +65,9 @@ def GetIdType(Str):
|
|||
Type = DataClass.MODEL_UNKNOWN
|
||||
Str = Str.replace('#', '# ')
|
||||
List = Str.split()
|
||||
if List[1] == 'include':
|
||||
if len(List) < 2:
|
||||
pass
|
||||
elif List[1] == 'include':
|
||||
Type = DataClass.MODEL_IDENTIFIER_INCLUDE
|
||||
elif List[1] == 'define':
|
||||
Type = DataClass.MODEL_IDENTIFIER_MACRO_DEFINE
|
||||
|
|
Loading…
Reference in New Issue