tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BaseTools/VfrCompile: Resolve uninit class variables in constructor 

The commit initializes those possibly uninitialized class variables in
class constructors.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Hao Wu 2017-12-18 10:11:57 +08:00
parent d837f33ab0
commit b748e35c2b
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
BaseTools/Source/C/VfrCompile/VfrError.cpp
View File

@ -67,6 +67,7 @@ CVfrErrorHandle::CVfrErrorHandle (
mScopeRecordListTail = NULL; mScopeRecordListTail = NULL;
mVfrErrorHandleTable = VFR_ERROR_HANDLE_TABLE; mVfrErrorHandleTable = VFR_ERROR_HANDLE_TABLE;
mVfrWarningHandleTable = VFR_WARNING_HANDLE_TABLE; mVfrWarningHandleTable = VFR_WARNING_HANDLE_TABLE;
mWarningAsError = FALSE;
} }
CVfrErrorHandle::~CVfrErrorHandle ( CVfrErrorHandle::~CVfrErrorHandle (

6
BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
View File

@ -104,8 +104,13 @@ CFormPkg::CFormPkg (
SBufferNode *Node; SBufferNode *Node;
mPkgLength = 0; mPkgLength = 0;
mBufferSize = 0;
mBufferNodeQueueHead = NULL; mBufferNodeQueueHead = NULL;
mBufferNodeQueueTail = NULL;
mCurrBufferNode = NULL; mCurrBufferNode = NULL;
mReadBufferNode = NULL;
mReadBufferOffset = 0;
PendingAssignList = NULL;
Node = new SBufferNode; Node = new SBufferNode;
if (Node == NULL) { if (Node == NULL) {
@ -2421,6 +2426,7 @@ CIfrObj::CIfrObj (
mObjBinLen = (ObjBinLen == 0) ? gOpcodeSizesScopeTable[OpCode].mSize : ObjBinLen; mObjBinLen = (ObjBinLen == 0) ? gOpcodeSizesScopeTable[OpCode].mSize : ObjBinLen;
mObjBinBuf = ((DelayEmit == FALSE) && (gCreateOp == TRUE)) ? gCFormPkg.IfrBinBufferGet (mObjBinLen) : new CHAR8[EFI_IFR_MAX_LENGTH]; mObjBinBuf = ((DelayEmit == FALSE) && (gCreateOp == TRUE)) ? gCFormPkg.IfrBinBufferGet (mObjBinLen) : new CHAR8[EFI_IFR_MAX_LENGTH];
mRecordIdx = (gCreateOp == TRUE) ? gCIfrRecordInfoDB.IfrRecordRegister (0xFFFFFFFF, mObjBinBuf, mObjBinLen, mPkgOffset) : EFI_IFR_RECORDINFO_IDX_INVALUD; mRecordIdx = (gCreateOp == TRUE) ? gCIfrRecordInfoDB.IfrRecordRegister (0xFFFFFFFF, mObjBinBuf, mObjBinLen, mPkgOffset) : EFI_IFR_RECORDINFO_IDX_INVALUD;
mLineNo = 0;
assert (mObjBinBuf != NULL); assert (mObjBinBuf != NULL);

3
BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp
View File

@ -958,6 +958,7 @@ CVfrVarDataTypeDB::CVfrVarDataTypeDB (
mPackAlign = DEFAULT_PACK_ALIGN; mPackAlign = DEFAULT_PACK_ALIGN;
mPackStack = NULL; mPackStack = NULL;
mFirstNewDataTypeName = NULL; mFirstNewDataTypeName = NULL;
mCurrDataType = NULL;
InternalTypesListInit (); InternalTypesListInit ();
} }
@ -1605,6 +1606,7 @@ SVfrVarStorageNode::SVfrVarStorageNode (
IN EFI_VARSTORE_ID VarStoreId IN EFI_VARSTORE_ID VarStoreId
) )
{ {
memset (&mGuid, 0, sizeof (EFI_GUID));
if (StoreName != NULL) { if (StoreName != NULL) {
mVarStoreName = new CHAR8[strlen(StoreName) + 1]; mVarStoreName = new CHAR8[strlen(StoreName) + 1];
strcpy (mVarStoreName, StoreName); strcpy (mVarStoreName, StoreName);
@ -1616,6 +1618,7 @@ SVfrVarStorageNode::SVfrVarStorageNode (
mVarStoreType = EFI_VFR_VARSTORE_NAME; mVarStoreType = EFI_VFR_VARSTORE_NAME;
mStorageInfo.mNameSpace.mNameTable = new EFI_VARSTORE_ID[DEFAULT_NAME_TABLE_ITEMS]; mStorageInfo.mNameSpace.mNameTable = new EFI_VARSTORE_ID[DEFAULT_NAME_TABLE_ITEMS];
mStorageInfo.mNameSpace.mTableSize = 0; mStorageInfo.mNameSpace.mTableSize = 0;
mAssignedFlag = FALSE;
} }
SVfrVarStorageNode::~SVfrVarStorageNode ( SVfrVarStorageNode::~SVfrVarStorageNode (