tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DynamicTablesPkg: Update ASL build options 

The EdkII BaseTools have been updated to facilitate the
generation of C file containing AML data using the AmlToC
script. The build system follows the following sequence
for an ASL file compilation:
 - The ASL file is preprocessed using the C preprocessor
 - The Trim utility prunes the preprocessed file to removed
   unwanted data.
 - This file is compiled using an ASL compiler to generate
   an AML file.
 - The AmlToC python script reads the AML data and generates
   a C file with an array containing the AML data.
 - This C file containing a unique symbol name for the AML
   data array is then compiled with the firmware module.

This removes the dependency on the ACPICA iASL compiler's
"-tc" option which achieved the same effect but was less
portable. Therefore, remove the "-tc" option from the ASL
flags as this option is only been supported by the ACPICA
iASL compiler.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
This commit is contained in:
Pierre Gondois 2020-07-27 11:08:23 +01:00 committed by mergify[bot]
parent 2d0c42fdf2
commit b88d95bb5b
2 changed files with 4 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
DynamicTablesPkg/DynamicTables.dsc.inc
View File

@ -1,7 +1,7 @@
## @file
# Dsc include file for Dynamic Tables Framework.
#
# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.<BR>
# Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@ -10,7 +10,6 @@
[Defines]
[BuildOptions]
*_*_*_ASL_FLAGS = -tc -li -so
[LibraryClasses.common]
TableHelperLib|DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf

29
DynamicTablesPkg/Readme.md
View File

@ -68,22 +68,6 @@ information file is planned.
Also support for generating SMBIOS tables is planned and will be added
subsequently.
Related Modules
---------------
### ACPICA iASL compiler
The RAW table generator, used to process the DSDT/SSDT files depends on
the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing
the hex AML code. The "-tc" option of the iASL compiler has been enhanced to
support generation of an AML hex file (C header) with a unique symbol name
so that it is suitable for inclusion from a C source file.
Related Links
--------------
<https://github.com/acpica/acpica.git>
Supported Platforms
-------------------
1. Juno
@ -120,16 +104,9 @@ or
Prerequisites
-------------
ACPICA iASL compiler with the enhanced "-tc" option to support generation of
AML hex (C header) files with unique symbol names.
A patch *'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'*, dated 16 March 2018 (2018-03-16),
to enable this support has been integrated to the ACPICA source repository.
Ensure that the iASL compiler used for building *Dynamic Tables Framework* has this feature enabled.
This feature was made available in the *ACPICA Compiler update
[Version 20180508](https://www.acpica.org/node/156)*, dated 8 May 2018 (2018-05-08).
Ensure that the latest ACPICA iASL compiler is used for building *Dynamic Tables Framework*.
*Dynamic Tables Framework* has been tested using the following iASL compiler version:
[Version 20200717](https://www.acpica.org/node/183)*, dated 17 July, 2020.
Running CI builds locally