From bb1d8ee66943c3d126abbfc007159eb0fe458927 Mon Sep 17 00:00:00 2001
From: qwang12 <qwang12@6f19259b-4bc3-4df7-8a09-765794883524>
Date: Thu, 30 Oct 2008 07:31:31 +0000
Subject: [PATCH] Remove SafeFreePool from MemoryAllocationLib as this API's
name is misleading. Its implementation only check if a pointer is NULL. If a
garbage pointer is passed in, the gBS->FreePool will still ASSERT in debug
build and return error code.
It is recommended that module writer should keep track how a pointer is allocated and free it after use.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6305 6f19259b-4bc3-4df7-8a09-765794883524
---
MdePkg/Include/Library/MemoryAllocationLib.h | 14 -------------
.../MemoryAllocationLib.c | 19 ------------------
.../MemoryAllocationLib.c | 20 -------------------
3 files changed, 53 deletions(-)
diff --git a/MdePkg/Include/Library/MemoryAllocationLib.h b/MdePkg/Include/Library/MemoryAllocationLib.h
index 76a9f8a564..2e8780b750 100644
--- a/MdePkg/Include/Library/MemoryAllocationLib.h
+++ b/MdePkg/Include/Library/MemoryAllocationLib.h
@@ -383,18 +383,4 @@ FreePool (
IN VOID *Buffer
);
-/**
- Frees buffer that were previously allocated with one of the
- memory allocation functions in the Memory Allocation Library.
-
- @param Buffer Pointer to the buffer of pages
- to free.
-
-**/
-VOID
-EFIAPI
-SafeFreePool (
- IN VOID *Buffer
- );
-
#endif
diff --git a/MdePkg/Library/PeiMemoryAllocationLib/MemoryAllocationLib.c b/MdePkg/Library/PeiMemoryAllocationLib/MemoryAllocationLib.c
index f937369cc7..5df1ce6cfb 100644
--- a/MdePkg/Library/PeiMemoryAllocationLib/MemoryAllocationLib.c
+++ b/MdePkg/Library/PeiMemoryAllocationLib/MemoryAllocationLib.c
@@ -650,22 +650,3 @@ FreePool (
}
-/**
- Frees buffer that were previously allocated with one of the
- memory allocation functions in the Memory Allocation Library.
-
- @param Buffer Pointer to the buffer of pages
- to free.
-
-**/
-VOID
-EFIAPI
-SafeFreePool (
- IN VOID *Buffer
- )
-{
- //
- // PEI phase does not support to free pool, so leave it as NOP.
- //
-}
-
diff --git a/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c b/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c
index 1c1c879a5f..d4ac3b86e6 100644
--- a/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c
+++ b/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c
@@ -667,23 +667,3 @@ FreePool (
ASSERT_EFI_ERROR (Status);
}
-
-/**
- Frees buffer that were previously allocated with one of the
- memory allocation functions in the Memory Allocation Library.
-
- @param Buffer Pointer to the buffer of pages
- to free.
-
-**/
-VOID
-EFIAPI
-SafeFreePool (
- IN VOID *Buffer
- )
-{
- if (Buffer != NULL) {
- FreePool (Buffer);
- }
-}
-