tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/Core: prevent re-acquire GCD memory lock 

This issue is hidden in current code but exposed by introduction
of freed-memory guard feature due to the fact that the feature
will turn all pool allocation to page allocation.

The solution is moving the memory allocation in CoreGetMemorySpaceMap()
to be out of the GCD memory map lock.

   CoreDumpGcdMemorySpaceMap()
=> CoreGetMemorySpaceMap()
=> CoreAcquireGcdMemoryLock () *
   AllocatePool()
=> InternalAllocatePool()
=> CoreAllocatePool()
=> CoreAllocatePoolI()
=> CoreAllocatePoolPagesI()
=> CoreAllocatePoolPages()
=> FindFreePages()
=> PromoteMemoryResource()
=> CoreAcquireGcdMemoryLock()  **

Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
Jian J Wang 2018-10-24 11:28:32 +08:00
parent 54efcfea81
commit bb685071c2
1 changed files with 63 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
MdeModulePkg/Core/Dxe/Gcd/Gcd.c
View File

@ -1691,10 +1691,10 @@ CoreGetMemorySpaceMap (
OUT EFI_GCD_MEMORY_SPACE_DESCRIPTOR **MemorySpaceMap
)
{
EFI_STATUS Status;
LIST_ENTRY *Link;
EFI_GCD_MAP_ENTRY *Entry;
EFI_GCD_MEMORY_SPACE_DESCRIPTOR *Descriptor;
UINTN DescriptorCount;
//
// Make sure parameters are valid
@ -1706,24 +1706,22 @@ CoreGetMemorySpaceMap (
return EFI_INVALID_PARAMETER;
}
*NumberOfDescriptors = 0;
*MemorySpaceMap = NULL;
//
// Take the lock, for entering the loop with the lock held.
//
CoreAcquireGcdMemoryLock ();
while (TRUE) {
//
// Count the number of descriptors
// Count descriptors. It might be done more than once because the
// AllocatePool() called below has to be running outside the GCD lock.
//
*NumberOfDescriptors = CoreCountGcdMapEntry (&mGcdMemorySpaceMap);
DescriptorCount = CoreCountGcdMapEntry (&mGcdMemorySpaceMap);
if (DescriptorCount == *NumberOfDescriptors) {
//
// Allocate the MemorySpaceMap
//
*MemorySpaceMap = AllocatePool (*NumberOfDescriptors * sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR));
if (*MemorySpaceMap == NULL) {
Status = EFI_OUT_OF_RESOURCES;
goto Done;
}
//
// Fill in the MemorySpaceMap
// Fill in the MemorySpaceMap if no memory space map change.
//
Descriptor = *MemorySpaceMap;
Link = mGcdMemorySpaceMap.ForwardLink;
@ -1733,11 +1731,50 @@ CoreGetMemorySpaceMap (
Descriptor++;
Link = Link->ForwardLink;
}
Status = EFI_SUCCESS;
//
// We're done; exit the loop with the lock held.
//
break;
}
Done:
//
// Release the lock before memory allocation, because it might cause
// GCD lock conflict in one of calling path in AllocatPool().
//
CoreReleaseGcdMemoryLock ();
return Status;
//
// Allocate memory to store the MemorySpaceMap. Note it might be already
// allocated if there's map descriptor change during memory allocation at
// last time.
//
if (*MemorySpaceMap != NULL) {
FreePool (*MemorySpaceMap);
}
*MemorySpaceMap = AllocatePool (DescriptorCount *
sizeof (EFI_GCD_MEMORY_SPACE_DESCRIPTOR));
if (*MemorySpaceMap == NULL) {
*NumberOfDescriptors = 0;
return EFI_OUT_OF_RESOURCES;
}
//
// Save the descriptor count got before for another round of check to make
// sure we won't miss any, since we have code running outside the GCD lock.
//
*NumberOfDescriptors = DescriptorCount;
//
// Re-acquire the lock, for the next iteration.
//
CoreAcquireGcdMemoryLock ();
}
//
// We exited the loop with the lock held, release it.
//
CoreReleaseGcdMemoryLock ();
return EFI_SUCCESS;
}