tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg: Enhance the debug message for InstallProtocolInterface 

Current code is using debug message like below for
InstallProtocolInterface.
InstallProtocolInterface: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX XXX

User could not know whether the installation is failed or not by the
debug message, for example, the code below does not initialize Handle
before calling InstallProtocolInterface, EFI_INVALID_PARAMETER will be
returned.
  EFI_HANDLE Handle;
  Status = gBS->InstallProtocolInterface (
                  &Handle,
                  &XXX,
                  EFI_NATIVE_INTERFACE,
                  XXX
                  );

This patch is to add additional debug message if the installation
is failed and specific debug message for the case that the input
handle is invalid.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Star Zeng 2017-06-21 13:28:26 +08:00
parent b243ead0aa
commit c01f13d52a
2 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
MdeModulePkg/Core/Dxe/Hand/Handle.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
UEFI handle & protocol handling. UEFI handle & protocol handling.
Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -428,11 +428,12 @@ CoreInstallProtocolInterfaceNotify (
// in the system // in the system
// //
InsertTailList (&gHandleList, &Handle->AllHandles); InsertTailList (&gHandleList, &Handle->AllHandles);
} } else {
Status = CoreValidateHandle (Handle);
Status = CoreValidateHandle (Handle); if (EFI_ERROR (Status)) {
if (EFI_ERROR (Status)) { DEBUG((DEBUG_ERROR, "InstallProtocolInterface: input handle at 0x%x is invalid\n", Handle));
goto Done; goto Done;
}
} }
// //
@ -491,6 +492,7 @@ Done:
if (Prot != NULL) { if (Prot != NULL) {
CoreFreePool (Prot); CoreFreePool (Prot);
} }
DEBUG((DEBUG_ERROR, "InstallProtocolInterface: %g %p failed with %r\n", Protocol, Interface, Status));
} }
return Status; return Status;

14
MdeModulePkg/Core/PiSmmCore/Handle.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
SMM handle & protocol handling. SMM handle & protocol handling.
Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR> Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available This program and the accompanying materials are licensed and made available
under the terms and conditions of the BSD License which accompanies this under the terms and conditions of the BSD License which accompanies this
distribution. The full text of the license may be found at distribution. The full text of the license may be found at
@ -287,11 +287,12 @@ SmmInstallProtocolInterfaceNotify (
// in the system // in the system
// //
InsertTailList (&gHandleList, &Handle->AllHandles); InsertTailList (&gHandleList, &Handle->AllHandles);
} } else {
Status = SmmValidateHandle (Handle);
Status = SmmValidateHandle (Handle); if (EFI_ERROR (Status)) {
if (EFI_ERROR (Status)) { DEBUG((DEBUG_ERROR, "SmmInstallProtocolInterface: input handle at 0x%x is invalid\n", Handle));
goto Done; goto Done;
}
} }
// //
@ -340,6 +341,7 @@ Done:
if (Prot != NULL) { if (Prot != NULL) {
FreePool (Prot); FreePool (Prot);
} }
DEBUG((DEBUG_ERROR, "SmmInstallProtocolInterface: %g %p failed with %r\n", Protocol, Interface, Status));
} }
return Status; return Status;
} }