mirror of https://github.com/acidanthera/audk.git
OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with declaration
"Platform.h" declares the AmdSevInitialize() function without EFIAPI, but the definition in "AmdSev.c" includes EFIAPI. GCC toolchains without LTO do not catch this error because "AmdSev.c" does not include "Platform.h"; i.e. the declaration used by callers such as "Platform.c" is not actually matched against the function definition at build time. With LTO enabled, the mismatch is found -- however, as a warning only, due to commitf8d0b96629
("BaseTools GCC5: disable warnings-as-errors for now", 2016-08-03). Include the header in the C file (which turns the issue into a hard build error on all GCC toolchains), plus sync the declaration from the header file to the C file. There's been no functional breakage because AmdSevInitialize() takes no parameters. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Brijesh Singh <brijesh.singh@amd.com> Cc: Jordan Justen <jordan.l.justen@intel.com> Fixes:13b5d743c8
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
This commit is contained in:
parent
3dbf922901
commit
c0d221a348
|
@ -23,6 +23,8 @@
|
|||
#include <Register/Amd/Cpuid.h>
|
||||
#include <Library/MemEncryptSevLib.h>
|
||||
|
||||
#include "Platform.h"
|
||||
|
||||
/**
|
||||
|
||||
Function checks if SEV support is available, if present then it sets
|
||||
|
@ -30,7 +32,6 @@
|
|||
|
||||
**/
|
||||
VOID
|
||||
EFIAPI
|
||||
AmdSevInitialize (
|
||||
VOID
|
||||
)
|
||||
|
|
Loading…
Reference in New Issue