tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-31 01:24:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg:Remove unneed FreePages for RuntimeHobCacheBuffer

Browse Source 
Remove unneed FreePages() for RuntimeHobCacheBuffer which is
allocated in PEI phase.
So the global variable mVariableRuntimeHobCacheBufferSize
also can be removed.

Signed-off-by: Dun Tan <dun.tan@intel.com>
This commit is contained in:
Dun Tan 2024-05-27 17:37:41 +08:00 committed by mergify[bot]
parent 645d9f6f8d
commit c1c2e474a2
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
View File

@ -54,7 +54,6 @@ VARIABLE_STORE_HEADER *mVariableRuntimeHobCacheBuffer = NULL;
VARIABLE_STORE_HEADER *mVariableRuntimeNvCacheBuffer = NULL; VARIABLE_STORE_HEADER *mVariableRuntimeNvCacheBuffer = NULL;
VARIABLE_STORE_HEADER *mVariableRuntimeVolatileCacheBuffer = NULL; VARIABLE_STORE_HEADER *mVariableRuntimeVolatileCacheBuffer = NULL;
UINTN mVariableBufferSize; UINTN mVariableBufferSize;
UINTN mVariableRuntimeHobCacheBufferSize;
UINTN mVariableBufferPayloadSize; UINTN mVariableBufferPayloadSize;
BOOLEAN mVariableRuntimeCachePendingUpdate; BOOLEAN mVariableRuntimeCachePendingUpdate;
BOOLEAN mVariableRuntimeCacheReadLock; BOOLEAN mVariableRuntimeCacheReadLock;
@ -578,10 +577,6 @@ CheckForRuntimeCacheSync (
// The HOB variable data may have finished being flushed in the runtime cache sync update // The HOB variable data may have finished being flushed in the runtime cache sync update
// //
if (mHobFlushComplete && (mVariableRuntimeHobCacheBuffer != NULL)) { if (mHobFlushComplete && (mVariableRuntimeHobCacheBuffer != NULL)) {
if (!EfiAtRuntime ()) {
FreePages (mVariableRuntimeHobCacheBuffer, EFI_SIZE_TO_PAGES (mVariableRuntimeHobCacheBufferSize));
}
mVariableRuntimeHobCacheBuffer = NULL; mVariableRuntimeHobCacheBuffer = NULL;
} }
} }
@ -1691,6 +1686,7 @@ SmmVariableReady (
EFI_STATUS Status; EFI_STATUS Status;
UINTN RuntimeNvCacheSize; UINTN RuntimeNvCacheSize;
UINTN RuntimeVolatileCacheSize; UINTN RuntimeVolatileCacheSize;
UINTN RuntimeHobCacheBufferSize;
Status = gBS->LocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mSmmVariable); Status = gBS->LocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mSmmVariable);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
@ -1720,13 +1716,13 @@ SmmVariableReady (
// Allocate runtime variable cache memory buffers. // Allocate runtime variable cache memory buffers.
// //
Status = GetRuntimeCacheInfo ( Status = GetRuntimeCacheInfo (
&mVariableRuntimeHobCacheBufferSize, &RuntimeHobCacheBufferSize,
&RuntimeNvCacheSize, &RuntimeNvCacheSize,
&RuntimeVolatileCacheSize, &RuntimeVolatileCacheSize,
&mVariableAuthFormat &mVariableAuthFormat
); );
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {
Status = InitVariableCache (&mVariableRuntimeHobCacheBuffer, &mVariableRuntimeHobCacheBufferSize); Status = InitVariableCache (&mVariableRuntimeHobCacheBuffer, &RuntimeHobCacheBufferSize);
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {
Status = InitVariableCache (&mVariableRuntimeNvCacheBuffer, &RuntimeNvCacheSize); Status = InitVariableCache (&mVariableRuntimeNvCacheBuffer, &RuntimeNvCacheSize);
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {