tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SecurityPkg/DxeImageVerificationLib: change IsCertHashFoundInDatabase name (CVE-2019-14575) 

IsCertHashFoundInDatabase() is actually used only for searching dbx,
according to the function logic, its comments and its use cases. Changing
it to IsCertHashFoundInDbx to avoid confusion.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1608
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Jian J Wang 2020-02-14 13:50:32 +08:00 committed by mergify[bot]
parent b1c1147059
commit c230c002ac
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c
View File

@ -829,7 +829,7 @@ AddImageExeInfo (
**/ **/
EFI_STATUS EFI_STATUS
IsCertHashFoundInDatabase ( IsCertHashFoundInDbx (
IN UINT8 *Certificate, IN UINT8 *Certificate,
IN UINTN CertSize, IN UINTN CertSize,
IN EFI_SIGNATURE_LIST *SignatureList, IN EFI_SIGNATURE_LIST *SignatureList,
@ -1362,7 +1362,7 @@ IsForbiddenByDbx (
// //
CertPtr = CertPtr + sizeof (UINT32) + CertSize; CertPtr = CertPtr + sizeof (UINT32) + CertSize;
Status = IsCertHashFoundInDatabase (Cert, CertSize, (EFI_SIGNATURE_LIST *)Data, DataSize, &RevocationTime, &IsFound); Status = IsCertHashFoundInDbx (Cert, CertSize, (EFI_SIGNATURE_LIST *)Data, DataSize, &RevocationTime, &IsFound);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
// //
// Error in searching dbx. Consider it as 'found'. RevocationTime might // Error in searching dbx. Consider it as 'found'. RevocationTime might
@ -1528,7 +1528,7 @@ IsAllowedByDb (
// //
// Here We still need to check if this RootCert's Hash is revoked // Here We still need to check if this RootCert's Hash is revoked
// //
Status = IsCertHashFoundInDatabase (RootCert, RootCertSize, (EFI_SIGNATURE_LIST *)DbxData, DbxDataSize, &RevocationTime, &IsFound); Status = IsCertHashFoundInDbx (RootCert, RootCertSize, (EFI_SIGNATURE_LIST *)DbxData, DbxDataSize, &RevocationTime, &IsFound);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
// //
// Error in searching dbx. Consider it as 'found'. RevocationTime might // Error in searching dbx. Consider it as 'found'. RevocationTime might