tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary use of FixedPcdxxx() functions and [FixedPcd] INF sections. These should only be used for PCDs that are used to pre-init global variables, pre-init global structures, or size arrays. 

Do some minor clean ups to INF files
 


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9867 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
mdkinney 2010-01-29 23:34:42 +00:00
parent cdccd99e24
commit c37f052fe9
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/IsaSerialDxe.inf
View File

@ -1,7 +1,7 @@
#/** @file
# Serial driver for standard UARTS on an ISA bus.
#
# Copyright (c) 2007 - 2009, Intel Corporation
# Copyright (c) 2007 - 2010, Intel Corporation
#
# All rights reserved. This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@ -19,7 +19,6 @@
FILE_GUID = 93B80003-9FB3-11d4-9A3A-0090273FC14D
MODULE_TYPE = UEFI_DRIVER
VERSION_STRING = 1.0
EFI_SPECIFICATION_VERSION = 0x00020000
ENTRY_POINT = InitializeIsaSerial
#
@ -32,7 +31,7 @@
# COMPONENT_NAME2 = gIsaSerialComponentName2
#
[Sources.common]
[Sources]
ComponentName.c
Serial.h
Serial.c
@ -58,11 +57,12 @@
gEfiDevicePathProtocolGuid ## TO_START
gEfiSerialIoProtocolGuid ## BY_START
[FixedPcd.common]
[FeaturePcd]
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdIsaBusSerialUseHalfHandshake|FALSE
[FixedPcd]
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|1
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|1
[FeaturePcd.common]
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdIsaBusSerialUseHalfHandshake|FALSE

8
IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/Serial.c
View File

@ -1117,7 +1117,7 @@ IsaSerialSetAttributes (
// Check for default settings and fill in actual values.
//
if (BaudRate == 0) {
BaudRate = FixedPcdGet64 (PcdUartDefaultBaudRate);
BaudRate = PcdGet64 (PcdUartDefaultBaudRate);
}
if (ReceiveFifoDepth == 0) {
@ -1129,15 +1129,15 @@ IsaSerialSetAttributes (
}
if (Parity == DefaultParity) {
Parity = (EFI_PARITY_TYPE)FixedPcdGet8 (PcdUartDefaultParity);
Parity = (EFI_PARITY_TYPE)PcdGet8 (PcdUartDefaultParity);
}
if (DataBits == 0) {
DataBits = FixedPcdGet8 (PcdUartDefaultDataBits);
DataBits = PcdGet8 (PcdUartDefaultDataBits);
}
if (StopBits == DefaultStopBits) {
StopBits = (EFI_STOP_BITS_TYPE) FixedPcdGet8 (PcdUartDefaultStopBits);
StopBits = (EFI_STOP_BITS_TYPE) PcdGet8 (PcdUartDefaultStopBits);
}
//
// 5 and 6 data bits can not be verified on a 16550A UART